Favicon link recreation makes it disappear
Reported by
luk...@fuugo.com,
May 9 2018
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36 Steps to reproduce the problem: 1. Open attached index.html, 2. TabStrip should show favicon with cat, 3. click "Recreate link tags" button, 4. TabStrip shows empty favicon/ no favicon. What is the expected behavior? The same favicon should be visible. It works ok on Firefox. What went wrong? When the link tags are recreated the favicon disappears but from the DOM tree perspective everything is the same as before. Did this work before? N/A Chrome version: 66.0.3359.139 Channel: stable OS Version: 10.0 Flash Version: When we switch the order of the link tags eg. rel="apple-touch-icon" first and rel="icon" second everything works as expected.
,
May 10 2018
Able to reproduce the issue on reported version 66.0.3359.139 and the same is not seen on latest canary 68.0.3426.0 and Beta 67.0.3396.40 using Windows10, Ubuntu 14.04 & Mac 10.12.6, as the issue is in 67.0.3396 branch builds, hence providing manual change log from omahaproxy Reverse Bisect Info: ================ Last Bad build: 67.0.3396.20 First Good build: 67.0.3396.22 Change Log: https://chromium.googlesource.com/chromium/src/+log/67.0.3396.20..67.0.3396.22?pretty=fuller&n=10000 Commit: https://chromium.googlesource.com/chromium/src/+/d5a4d9aa74e836244723688968778a02df9a7a38 Reviewed-on: https://chromium-review.googlesource.com/1025851 @Naoki Fukino: Please confirm the issue and help in re-assigning if it is not related to your change, please help in merging it to M-66 if applicable Adding ReleaseBlock-Stable as it seems recent break, feel free to remove it if not applicable, tentatively adding UI>Browser>TabStrip component. Thanks!
,
May 14 2018
fukino@, Friendly ping to get an update on this issue as it is marked as M66 stable blocker. Thanks..!
,
May 14 2018
This issue is not related to my change. My change is built only on Chrome OS, and does not affect Chrome browser. In the CL list (https://chromium.googlesource.com/chromium/src/+/d5a4d9aa74e836244723688968778a02df9a7a38), it seems https://chromium-review.googlesource.com/c/chromium/src/+/1030350 touches favicon-related code. mastiz@, could you take a looks and see if your change is related? Thanks!
,
May 14 2018
Thanks for filing the bug! This issue was around for a couple a milestones until it was fixed in M67. Marking as dup. |
||||
►
Sign in to add a comment |
||||
Comment 1 by susan.boorgula@chromium.org
, May 9 2018