New issue
Advanced search Search tips

Issue 841178 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add tests for notification delegation

Project Member Reported by peconn@chromium.org, May 9 2018

Issue description

Create tests to ensure notification delegation works!

Previously when attempting to write tests I had issues starting TestTrustedWebActivityService (a subclass of TrustedWebActivityService) that was in ../../chrome/android/javatests/src/org/chromium/chrome/browser/browserservices/TestTrustedWebActivityService.java.

I think this was due to some strangeness with classes in different apks. Error:

java.lang.RuntimeException: Unable to instantiate service android.support.customtabs.trusted.TrustedWebActivityService:
java.lang.ClassNotFoundException: Didn't find class "android.support.customtabs.trusted.TrustedWebActivityService" on path: DexPathList[[
           zip file "/system/framework/android.test.mock.jar",
           zip file "/system/framework/org.apache.http.legacy.boot.jar",
           zip file "/system/framework/android.test.runner.jar",
           zip file "/data/app/org.chromium.chrome.tests-32eE3ouaLKR3ADOqH_EGCw==/base.apk"
         ],
         nativeLibraryDirectories=[
           /data/app/org.chromium.chrome.tests-32eE3ouaLKR3ADOqH_EGCw==/lib/arm64,
           /system/lib64
         ]
       ]                                                          
       at android.app.ActivityThread.handleCreateService(ActivityThread.java:3479)
       at android.app.ActivityThread.access$1200(ActivityThread.java:197)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1627)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:164)                 
       at android.app.ActivityThread.main(ActivityThread.java:6591)
       at java.lang.reflect.Method.invoke(Native Method) 
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:826)
Caused by: java.lang.ClassNotFoundException: Didn't find class "android.support.customtabs.trusted.TrustedWebActivityService" on path: DexPathList[[
           zip file "/system/framework/android.test.mock.jar",
           zip file "/system/framework/org.apache.http.legacy.boot.jar",
           zip file "/system/framework/android.test.runner.jar",
           zip file "/data/app/org.chromium.chrome.tests-32eE3ouaLKR3ADOqH_EGCw==/base.apk"
         ],
         nativeLibraryDirectories=[
           /data/app/org.chromium.chrome.tests-32eE3ouaLKR3ADOqH_EGCw==/lib/arm64,
           /system/lib64
         ]
       ]
       at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:125)
       at java.lang.ClassLoader.loadClass(ClassLoader.java:379) 
       at java.lang.ClassLoader.loadClass(ClassLoader.java:312) 
       at android.app.AppComponentFactory.instantiateServicAppComponentFactory.java:103)
       at android.app.ActivityThread.handleCreateService(ActivityThread.java:3474)
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599

commit 0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599
Author: Peter E Conn <peconn@chromium.org>
Date: Thu May 17 10:56:03 2018

🔁 Create tests for TrustedWebActivityClient.

Bug:  841178 
Change-Id: I7aad6a4f8288941cb78231da010a972b4eafad06
Reviewed-on: https://chromium-review.googlesource.com/1059786
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559488}
[modify] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/android/BUILD.gn
[modify] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/android/java_sources.gni
[modify] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/android/javatests/AndroidManifest.xml
[add] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/android/javatests/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityClientTest.java
[modify] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/test/android/chrome_public_test_support/AndroidManifest.xml
[modify] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/test/android/chrome_public_test_support/BUILD.gn
[add] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/test/android/test_trusted_web_activity/BUILD.gn
[add] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/test/android/test_trusted_web_activity/src/org/chromium/chrome/browser/browserservices/ActivityWithDeepLink.java
[add] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/test/android/test_trusted_web_activity/src/org/chromium/chrome/browser/browserservices/MessengerService.java
[add] https://crrev.com/0bc0701b00dc3bd10832d05bec9a6a8d2d5e7599/chrome/test/android/test_trusted_web_activity/src/org/chromium/chrome/browser/browserservices/TestTrustedWebActivityService.java

Comment 2 by peconn@chromium.org, May 17 2018

Status: Fixed (was: Assigned)

Sign in to add a comment