Reduce Fuchsia package header includes by headers in //base |
|
Issue descriptionWe currently have |public_deps| including several Fuchsia dependencies of //base, rather than putting those in |deps|, due to public //base headers which include them, and so require callers to have them on their includes path. We should audit the include sites and remove them if possible.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fd4e46f603746981cfca9490ce6ea49ed11928c commit 8fd4e46f603746981cfca9490ce6ea49ed11928c Author: Wez <wez@chromium.org> Date: Wed May 09 10:54:16 2018 Roll Fuchsia SDK from 230c2287820f to c29af1551ab7 The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Bug: 841171 Change-Id: I4c23bacf4f44799b63cebefe51a5f94965408bd8 Reviewed-on: https://chromium-review.googlesource.com/1051263 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557142} [modify] https://crrev.com/8fd4e46f603746981cfca9490ce6ea49ed11928c/base/BUILD.gn [modify] https://crrev.com/8fd4e46f603746981cfca9490ce6ea49ed11928c/build/config/fuchsia/BUILD.gn [modify] https://crrev.com/8fd4e46f603746981cfca9490ce6ea49ed11928c/build/fuchsia/sdk.sha1 [modify] https://crrev.com/8fd4e46f603746981cfca9490ce6ea49ed11928c/third_party/fuchsia-sdk/BUILD.gn |
|
►
Sign in to add a comment |
|
Comment 1 by w...@chromium.org
, May 9 2018