Crostini setup flow errors get set multiple times |
|||||
Issue descriptionDue to the way callbacks and observers interact, if there is an error with the setup flow HandleError will get called twice - once for the actual error and once at the end. The last one will always get called and overwrite the dialog's error message.
,
May 9 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63b8c30f2764fff51f7235f1be643bfc6e1914b1 commit 63b8c30f2764fff51f7235f1be643bfc6e1914b1 Author: Ben Wells <benwells@chromium.org> Date: Thu May 10 08:21:02 2018 Only show the first error to the user in the Crostini setup flow. The CrostiniManager can send multiple error callbacks. Only the first one should be shown to the user. Bug: 841158 Change-Id: If21222f81b609559a462a73af8c5a7bc911592fb Reviewed-on: https://chromium-review.googlesource.com/1051406 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557477} [modify] https://crrev.com/63b8c30f2764fff51f7235f1be643bfc6e1914b1/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc
,
May 10 2018
,
May 22 2018
,
May 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vapier@chromium.org
, May 9 2018