Writing direction of URL textbox in bookmark does not change even after selection 'right to left' option.
Reported by
pranjali...@etouch.net,
May 9 2018
|
||||||
Issue descriptionChrome Version: 67.0.3396.40 (Official Build) 4d4e946fc6b643fe97197ead24e3a6f414385ad3-refs/branch-heads/3396@{#527} (64 bit) OS: Mac(10.12.6 , 10.13.1 , 10.13.5) OS Steps to reproduce: 1. Launch chrome ,click on 'bookmark' icon and click on 'More' button. 2. Now right click on URL textbox and select 'Right to left' from context menu. 3. Observe. Actual Result: After selecting 'right to left 'option , writing direction of text does not change. Expected Result: After selecting 'right to left' option ,writing direction of text should get change. This is a Non-regression issue seen from 'M66' series i.e 66.0.3358.0 Note:Issue is not seen on Linux(14.04 LTS) and Win(7,8,8.1,10) OS
,
May 9 2018
,
May 15 2018
,
May 15 2018
,
May 16 2018
,
May 16 2018
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a0f297511723072016728325cca5aee6ebc0f53 commit 3a0f297511723072016728325cca5aee6ebc0f53 Author: Tessa Nijssen <tnijssen@google.com> Date: Thu May 17 02:06:44 2018 Set Horizontal Alignment for Textfields Previously, when a Textfield instance changed its text direction, no change was made to its horizontal alignment. Now, ChangeTextDirectionAndLayoutAlignment() calls SetHorizontalAlignment() with the correct alignment based on text direction. Text direction Horizontal alignment Right-to-left -> Aligned right Left-to-right -> Aligned left This fixes a bug where toggling RTL in a Textfield did not change the text writing direction. A unit test was also added to test ChangeTextDirectionAndLayoutAlignment(). This test checks that a call to the method properly updates the textfield's text direction and horizontal alignment. Bug: 841123 Change-Id: I8dadc1272a3474dc72ae9470bdc7d9949e8fd854 Reviewed-on: https://chromium-review.googlesource.com/1060626 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559397} [modify] https://crrev.com/3a0f297511723072016728325cca5aee6ebc0f53/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/3a0f297511723072016728325cca5aee6ebc0f53/ui/views/controls/textfield/textfield_unittest.cc
,
May 18 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rbasuvula@chromium.org
, May 9 2018