New issue
Advanced search Search tips

Issue 841119 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add group for FUSE mounter users.

Project Member Reported by dats@chromium.org, May 9 2018

Issue description

This will allow to provide cros-disks access to their data without exposing it to the world.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/5e58669ab9bd5c742f338d40ddc288503ae581f6

commit 5e58669ab9bd5c742f338d40ddc288503ae581f6
Author: Sergei Datsenko <dats@google.com>
Date: Tue Jun 05 00:23:19 2018

cros-disks: Set up group for FUSE daemons

Set up a group for uniting all FUSE-based helpers so they can access
temporary directories created for them by cros-disks. Remove unnecessary
access to chronos files from those users.

BUG= chromium:841119 
TEST=Check display-accts.py output, build image and try to mount exfat
and ntfs usb drive and rar archive.
CQ-DEPEND=CL:1080350

Change-Id: Id937ceabb3f2b019ea88d37d121b1126fa1b0e36
Reviewed-on: https://chromium-review.googlesource.com/1060953
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/5e58669ab9bd5c742f338d40ddc288503ae581f6/profiles/base/accounts/group/chronos-access
[add] https://crrev.com/5e58669ab9bd5c742f338d40ddc288503ae581f6/profiles/base/accounts/group/fuse

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5dc9da9dea970f5a9c45b35326612eeacf6d7523

commit 5dc9da9dea970f5a9c45b35326612eeacf6d7523
Author: Sergei Datsenko <dats@google.com>
Date: Tue Jun 05 00:23:19 2018

cros-disks: FUSE daemons are not in chronos-access anymore.

BUG= chromium:841119 
TEST=Pre-CQ
CQ-DEPEND=CL:1060953

Change-Id: I689d1cad0402520d07ade850dae80cf3382f6c05
Reviewed-on: https://chromium-review.googlesource.com/1080350
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/5dc9da9dea970f5a9c45b35326612eeacf6d7523/cros/test/usergroup_baseline.py

Comment 3 by dats@chromium.org, Jun 5 2018

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc6e786d406aea1df1526cbe9c65b4e15afb8a7

commit 7cc6e786d406aea1df1526cbe9c65b4e15afb8a7
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 05 01:55:33 2018

Roll src/third_party/chromite 9665e37..84e4547 (6 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9665e37..84e4547


git log 9665e37..84e4547 --date=short --no-merges --format='%ad %ae %s'
2018-06-05 dhanyaganesh@google.com 'tar: file changed as we read it' fix
2018-06-05 ayatane@chromium.org chromeos-infra-go-pre-cq: New build config
2018-06-05 dgarrett@google.com config_stages: Handle multiple config locations.
2018-06-05 ahassani@chromium.org paygen: Rename signature variables
2018-06-05 bmgordon@chromium.org cros_sdk: Remove unused toolchain overlay support
2018-06-05 dats@google.com cros-disks: FUSE daemons are not in chronos-access anymore.


Created with:
  gclient setdep -r src/third_party/chromite@84e4547

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:547055,chromium:845337, chromium:848020 , chromium:845614 ,chromium:845174, chromium:841119 
TBR=chrome-os-gardeners@chromium.org

Change-Id: I04ea4de88cd62923087594cce649f787b3b251b4
Reviewed-on: https://chromium-review.googlesource.com/1086328
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564344}
[modify] https://crrev.com/7cc6e786d406aea1df1526cbe9c65b4e15afb8a7/DEPS

Sign in to add a comment