New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841110 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: sk_color_space_ in icc_profile.cc

Project Member Reported by ClusterFuzz, May 9 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5658335668600832

Fuzzer: libFuzzer_color_transform_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  sk_color_space_ in icc_profile.cc
  gfx::ICCProfile::Internals::Initialize
  gfx::ICCProfile::Internals::Internals
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=556845:556862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5658335668600832

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 9 2018

Components: Internals>Core UI>GFX
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 9 2018

Cc: hubbe@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, May 9 2018

Cc: brianosman@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Switch to using skcms for ICC profile parsing by brianosman@google.com - https://chromium.googlesource.com/chromium/src/+/e6ae8f4c3bf66e5bf6641711062c15ea61df9cd2

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/01b2244e0f7a835430b5a6882412001e6a71cf06

commit 01b2244e0f7a835430b5a6882412001e6a71cf06
Author: Brian Osman <brianosman@google.com>
Date: Wed May 09 14:34:05 2018

When validating transfer fns, allow D > 1

This matches behavior in skcms. Previously, we could get a profile with
a large D value, skcms would decide it was okay, but then we'd be unable
to create an SkColorSpace from it.

Bug:  chromium:841110 
Change-Id: I2418a0b770172bff62a14d2d4d0fc7ba70f33e0b
Reviewed-on: https://skia-review.googlesource.com/126920
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/01b2244e0f7a835430b5a6882412001e6a71cf06/src/core/SkColorSpacePriv.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8254aff5fde0f5fa91a7334c3e45e5fd9e05edd5

commit 8254aff5fde0f5fa91a7334c3e45e5fd9e05edd5
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 09 17:36:46 2018

Roll src/third_party/skia/ a2595f925..97c110860 (10 commits; 1 trivial rolls)

https://skia.googlesource.com/skia.git/+log/a2595f925596..97c110860758

$ git log a2595f925..97c110860 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 egdaniel Revert "SkAdvancedTypefaceMetrics: factor out GlyphToUnicode"
2018-05-09 skcms-skia-autoroll Roll skia/third_party/skcms 289cedc..f771d23 (1 commits)
2018-05-09 mtklein clean up some SkDebugf()
2018-05-09 csmartdalton ccpr: Cleanup on-flush path stats
2018-05-09 robertphillips Cleanup SK_IGNORE_BLUR_IMAGE_FILTER_FIX (since Chrome no longer uses it)
2018-05-09 fmalita [skottie] Null value crash in json::ValueRef::toString()
2018-05-09 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ d4e488eb6..0641aebe3 (1 commit)
2018-05-09 brianosman When validating transfer fns, allow D > 1
2018-04-10 halcanary SkAdvancedTypefaceMetrics: factor out GlyphToUnicode

Created with:
  roll-dep src/third_party/skia
BUG= chromium:841110 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I7ba86504e42883b6f8243a89fad3b3db2ebdf181
Reviewed-on: https://chromium-review.googlesource.com/1052225
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557233}
[modify] https://crrev.com/8254aff5fde0f5fa91a7334c3e45e5fd9e05edd5/DEPS

Project Member

Comment 6 by ClusterFuzz, May 10 2018

ClusterFuzz has detected this issue as fixed in range 557225:557237.

Detailed report: https://clusterfuzz.com/testcase?key=5658335668600832

Fuzzer: libFuzzer_color_transform_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  sk_color_space_ in icc_profile.cc
  gfx::ICCProfile::Internals::Initialize
  gfx::ICCProfile::Internals::Internals
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=556845:556862
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=557225:557237

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5658335668600832

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, May 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 5658335668600832 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment