New issue
Advanced search Search tips

Issue 841099 link

Starred by 2 users
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: May 2018
Cc:
karandeepb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Extensions Click-to-Script: Change experiment default to not withhold automatically

Project Member Reported by rdevlin....@chromium.org, May 9 2018 
The first phase of click-to-script should not withhold permissions.  The default may change in a later phase, when there is better install-time support.

As a corollary of this, we should remove our existing extra install prompt warning, and just display the appropriate host warnings instead.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9bf5454fb328977b5655f02f39f8722b6c28c3a

commit d9bf5454fb328977b5655f02f39f8722b6c28c3a
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Sat May 12 01:02:20 2018

[Extensions Click-to-Script] Change default to allowing host permissions

Change the default behavior of the kRuntimeHostPermissions feature to
allow extensions to have origin access, rather than defaulting to
withholding permission. In the first stage of click-to-script, we don't
want to change any defaults.

Bug:  841099 
Change-Id: Ibdcbfb0fd9ecc535af73a1bd9048e196eab135e1
Reviewed-on: https://chromium-review.googlesource.com/1052684
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558079}
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/extension_action_runner_unittest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/extension_install_prompt_unittest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/permissions_updater.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/permissions_updater_unittest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/scripting_permissions_modifier.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/scripting_permissions_modifier.h
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/browser/ui/extensions/blocked_action_bubble_browsertest.cc
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/test/data/extensions/api_test/developer/generated_output/behllobkkfkfnphdnhnkndlbkcpglgmj.json
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/test/data/extensions/api_test/developer/generated_output/bjafgdebaacbbbecmhlhpofkepfkgcpa.json
[modify] https://crrev.com/d9bf5454fb328977b5655f02f39f8722b6c28c3a/chrome/test/data/extensions/api_test/developer/generated_output/hpiknbiabeeppbpihjehijgoemciehgk.json
Project Member

Comment 2 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af3bc79c29cbd9b3360154959856f451a7b25f4

commit 7af3bc79c29cbd9b3360154959856f451a7b25f4
Author: Timothy Loh <timloh@chromium.org>
Date: Mon May 14 04:59:44 2018

Revert "[Extensions Click-to-Script] Change default to allowing host permissions"

This reverts commit d9bf5454fb328977b5655f02f39f8722b6c28c3a.

Reason for revert: Breaks ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy on Linux Debug

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=not_site_per_process_browser_tests&tests=ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8946590247605008336%2F%2B%2Fsteps%2Fnot_site_per_process_browser_tests%2F0%2Flogs%2FExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy%2F0

Original change's description:
> [Extensions Click-to-Script] Change default to allowing host permissions
>
> Change the default behavior of the kRuntimeHostPermissions feature to
> allow extensions to have origin access, rather than defaulting to
> withholding permission. In the first stage of click-to-script, we don't
> want to change any defaults.
>
> Bug:  841099 
> Change-Id: Ibdcbfb0fd9ecc535af73a1bd9048e196eab135e1
> Reviewed-on: https://chromium-review.googlesource.com/1052684
> Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558079}

TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  841099 ,  842466 
Change-Id: Id37af8c43bbf30d8963852df9b29b58ff3ca5a53
Reviewed-on: https://chromium-review.googlesource.com/1056887
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558198}
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/extension_action_runner_unittest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/extension_install_prompt_unittest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/permissions_updater.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/permissions_updater_unittest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/scripting_permissions_modifier.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/scripting_permissions_modifier.h
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/browser/ui/extensions/blocked_action_bubble_browsertest.cc
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/test/data/extensions/api_test/developer/generated_output/behllobkkfkfnphdnhnkndlbkcpglgmj.json
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/test/data/extensions/api_test/developer/generated_output/bjafgdebaacbbbecmhlhpofkepfkgcpa.json
[modify] https://crrev.com/7af3bc79c29cbd9b3360154959856f451a7b25f4/chrome/test/data/extensions/api_test/developer/generated_output/hpiknbiabeeppbpihjehijgoemciehgk.json
Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f355f1ded742b239d41a858bd81696db672193c9

commit f355f1ded742b239d41a858bd81696db672193c9
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon May 14 15:27:24 2018

[Reland][Extensions Click-to-Script] Change default to allowing host permissions

Change the default behavior of the kRuntimeHostPermissions feature to
allow extensions to have origin access, rather than defaulting to
withholding permission. In the first stage of click-to-script, we don't
want to change any defaults.

Reland notes: the original patch caused
ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy to fail
because it relies on the permissions being withheld, but the patch
didn't update it with a call to withhold permissions.

TBR=karandeepb@chromium.org

Bug:  841099 
Change-Id: If913aee7e14b7ea89c751528b8402d07a514b047
Reviewed-on: https://chromium-review.googlesource.com/1057433
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558317}
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/extension_action_runner_unittest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/extension_install_prompt_unittest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/permissions_updater.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/permissions_updater_unittest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/scripting_permissions_modifier.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/scripting_permissions_modifier.h
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/browser/ui/extensions/blocked_action_bubble_browsertest.cc
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/test/data/extensions/api_test/developer/generated_output/behllobkkfkfnphdnhnkndlbkcpglgmj.json
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/test/data/extensions/api_test/developer/generated_output/bjafgdebaacbbbecmhlhpofkepfkgcpa.json
[modify] https://crrev.com/f355f1ded742b239d41a858bd81696db672193c9/chrome/test/data/extensions/api_test/developer/generated_output/hpiknbiabeeppbpihjehijgoemciehgk.json
Project Member

Comment 4 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6e136ada6c5826499cca2a82af6749051319c85

commit d6e136ada6c5826499cca2a82af6749051319c85
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue May 15 23:39:32 2018

[Extensions] Remove withheld permissions from install prompt

We no longer need to display withheld permissions in the
extension install prompt, even with the runtime host permissions
feature enabled. Clean up the relevant code.

Bug:  841099 

Change-Id: If295d36859f8664928c83923a010057f2fb4d1c1
Reviewed-on: https://chromium-review.googlesource.com/1053178
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558882}
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/app/generated_resources.grd
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/chromeos/extensions/public_session_permission_helper.cc
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/extensions/extension_install_prompt.h
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/extensions/extension_install_prompt_unittest.cc
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/extensions/external_install_error.cc
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/d6e136ada6c5826499cca2a82af6749051319c85/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Comment 5 by rdevlin....@chromium.org, May 17 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment