servod: investigate None return type over xmlrpc |
||
Issue descriptionWe currently allow for xmlrcp to return multiple supported datatypes. Even though None is supposed to be allowed, it still causes issues, and raises errors. This bug is to track efforts to investigate how to mitigate this: option (1): return "None" as a string option (2): return 0 or '' so that they behave as functionally None option (3): dig into, and see if a pure None type can work, or if that's infeasible.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/b5fe0f1391d8d19f9788e38bd96c337677ef666d commit b5fe0f1391d8d19f9788e38bd96c337677ef666d Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Date: Fri May 11 06:18:03 2018 sysconfig: don't allow raw None return Even though we have allow_none=True specified, there's still issues with None values across xmlrpc. Disallow None return by casting it to a string (as done previously). BUG=chromium:840961 BUG=chromium:841097 TEST=manual test cr50 ccd servod dut-control -p $PORT ec_uart_parity ec_uart_parity:None Change-Id: I505cdaf47dd04db60970743588aec654efce2c3e Reviewed-on: https://chromium-review.googlesource.com/1051147 Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> [modify] https://crrev.com/b5fe0f1391d8d19f9788e38bd96c337677ef666d/servo/servo_server.py [modify] https://crrev.com/b5fe0f1391d8d19f9788e38bd96c337677ef666d/servo/system_config.py
,
Jan 18
(4 days ago)
De-prioritizing to '3' given 'available' status & removing milestones accordingly. If you disagree please mark 'untriaged'. |
||
►
Sign in to add a comment |
||
Comment 1 by coconutruben@chromium.org
, May 9 2018