New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841085 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 835984



Sign in to add a comment

PersonalDataManagerTest.GetProfileSuggestions_InvalidData is flaky

Project Member Reported by zmo@chromium.org, May 9 2018

Issue description

Comment 1 by zmo@chromium.org, May 9 2018

This test is just added here:

https://chromium-review.googlesource.com/c/chromium/src/+/998132

Comment 2 by zmo@chromium.org, May 9 2018

Blocking: 835984

Comment 3 by kbr@chromium.org, May 9 2018

Cc: kbr@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3e2686c6b552941316a656c73e0aade89119b7

commit ff3e2686c6b552941316a656c73e0aade89119b7
Author: Zhenyao Mo <zmo@chromium.org>
Date: Wed May 09 01:07:23 2018

Revert "[autofill] Suppress the use of invalid profile data."

This reverts commit c8d6aa1656c546f1bbef7273af2662d611bcd68c.

Reason for revert:  crbug.com/841085  (this is blocking CQ)

Bug:  841085 

Original change's description:
> [autofill] Suppress the use of invalid profile data.
> 
> This CL adds feature flags that causes Chrome to suppress suggestions,
> votes and quality metrics based on profile data which has been flagged
> as likely invalid.
> 
> This will allow Chrome Team to evaluate the utility of attempting to
> filter out this data.
> 
> Bug: 835984
> Change-Id: I63f51ac893d2bf657af9eb136d920cb0b7f2bddd
> Reviewed-on: https://chromium-review.googlesource.com/998132
> Commit-Queue: Roger McFarlane <rogerm@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556900}

TBR=rogerm@chromium.org,jwd@chromium.org,sebsg@chromium.org

Change-Id: I549b1fa0af8f367a62e8afa57fcda43ee592fa12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 835984
Reviewed-on: https://chromium-review.googlesource.com/1051025
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557040}
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/autofill_profile.h
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/autofill_profile_unittest.cc
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/ff3e2686c6b552941316a656c73e0aade89119b7/tools/metrics/histograms/histograms.xml

Comment 6 by zmo@chromium.org, May 9 2018

Owner: rogerm@chromium.org
Status: Assigned (was: Untriaged)
Sorry to revert your CL, but it's blocking the CQ, so revert to get CQ rolling, then you can take your time investigating.
it is also flaky on other platforms as well (see  issue 841188 ).

Comment 8 by kbr@chromium.org, May 9 2018

Summary: PersonalDataManagerTest.GetProfileSuggestions_InvalidData is flaky (was: PersonalDataManagerTest.GetProfileSuggestions_InvalidData is flaky on android_n5x_swarming_rel)

Comment 9 by kbr@chromium.org, May 9 2018

Cc: rogerm@chromium.org
 Issue 841188  has been merged into this issue.
Status: Fixed (was: Assigned)
Fixed and relanded in https://chromium-review.googlesource.com//1053597

Sign in to add a comment