New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841072 link

Starred by 1 user
Status: Fixed
Owner:
█ stephanstross@google.com
Last visit > 30 days ago
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Task



Sign in to add a comment

net_perftests should be a test target

Project Member Reported by stephanstross@google.com, May 8 2018 
The target net:net_perftests was defined as an executable with the testonly=True flag. It should just be a test target.
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92fe507e00526807e5a3a53613f3e9d54cd52ae0

commit 92fe507e00526807e5a3a53613f3e9d54cd52ae0
Author: Stephan Stross <stephanstross@google.com>
Date: Sat May 12 01:47:33 2018

Make net_perftests target a test() instead of an executable().

It is necessary to change the target type of net_perftests because certain
build artifacts for fuchsia are only generated for test targets (such as
runner scripts) and they are needed for crrev.com/c/1031294


Change-Id: Ibd6b88fc1d4098b61a8e91cbdca66613383c2c79
Bug:  841072 ,  594965 
Reviewed-on: https://chromium-review.googlesource.com/1050888
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558090}
[modify] https://crrev.com/92fe507e00526807e5a3a53613f3e9d54cd52ae0/net/BUILD.gn

Comment 2 by stephanstross@google.com, May 14 2018

Status: Fixed (was: Untriaged)
CL 1050888 fixes this.
►

Sign in to add a comment