New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841068 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: May 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Move GetLatestRegressionRange to MasterFlakeAnalysis

Project Member Reported by lijeffrey@chromium.org, May 8 2018 
In order to deprecate DataPoint's blame_list, previous_build_git_hash, etc, the regression range must be available instead. Move the logic to calculate a regression range based on data points from lookback_algorithm into master_flake_analysis so other modules can use it
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7b5301f5c496216d1f6e9a687caf1747a467ad58

commit 7b5301f5c496216d1f6e9a687caf1747a467ad58
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu May 10 18:51:57 2018

[Findit] Flake Analyzer - Move function to get latest regression range to MasterFlakeAnalysis

A regression range should always be displayed for the latest progress of an analysis.
Additionally, the range can be used in place of storing data_point.blame_list, which
is deprecated. This change moves the logic to determine the latest available regression
range in a set of data points from services/flake_failure/lookback_algorithm.py into
model/flake/master_flake_analysis.py instead.

Bug:  841068 
Change-Id: I04b42e2f345ec18ed6654529a8f4b6acde37e3a7
Reviewed-on: https://chromium-review.googlesource.com/1050879
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/7b5301f5c496216d1f6e9a687caf1747a467ad58/appengine/findit/pipelines/flake_failure/next_commit_position_pipeline.py
[modify] https://crrev.com/7b5301f5c496216d1f6e9a687caf1747a467ad58/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/7b5301f5c496216d1f6e9a687caf1747a467ad58/appengine/findit/services/flake_failure/test/lookback_algorithm_test.py
[modify] https://crrev.com/7b5301f5c496216d1f6e9a687caf1747a467ad58/appengine/findit/model/flake/test/master_flake_analysis_test.py
[modify] https://crrev.com/7b5301f5c496216d1f6e9a687caf1747a467ad58/appengine/findit/services/flake_failure/lookback_algorithm.py

Comment 2 by lijeffrey@chromium.org, May 21 2018

Status: Verified (was: Assigned)
►

Sign in to add a comment