New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841054 link

Starred by 1 user
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
xiy...@chromium.org
█ hejq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 803291



Sign in to add a comment

Pass ui::MenuSeparatorType to ash through mojom::MenuItem

Project Member Reported by warx@chromium.org, May 8 2018 
As title
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d693faf738d02a235a620efe2f5926ad6f2aba2

commit 6d693faf738d02a235a620efe2f5926ad6f2aba2
Author: Qiang Xu <warx@google.com>
Date: Thu May 10 00:59:40 2018

cros: send MenuSeparatorType to ash

changes:
Add MenuSeparatorType to ash::mojom::MenuItem.

Bug:  841054 , 733662
Test: covered by tests. Emulator tests.
Change-Id: I7570369bbeac3a65cb536a52f6f8ef2837c28461
Reviewed-on: https://chromium-review.googlesource.com/1050881
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557401}
[modify] https://crrev.com/6d693faf738d02a235a620efe2f5926ad6f2aba2/ash/public/cpp/menu_struct_mojom_traits.h
[modify] https://crrev.com/6d693faf738d02a235a620efe2f5926ad6f2aba2/ash/public/cpp/menu_utils.cc
[modify] https://crrev.com/6d693faf738d02a235a620efe2f5926ad6f2aba2/ash/public/interfaces/menu.mojom
[modify] https://crrev.com/6d693faf738d02a235a620efe2f5926ad6f2aba2/ash/public/interfaces/menu.typemap

Comment 2 by warx@chromium.org, May 10 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment