New issue
Advanced search Search tips

Issue 841053 link

Starred by 1 user
Status: Fixed
Owner:
valleau@chromium.org
Closed: May 2018
Cc:
weifangsun@chromium.org
skau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Limit Editing Printer to Invalid Values

Project Member Reported by valleau@chromium.org, May 8 2018 
A user should not be able to edit an existing configured printer into a state which makes it unusable.

For example if a user attempts to change the protocol of USB printer to use IPP then it would no longer work.

In order to prevent this we should disable elements in the edit printer dialog that we don't want users to be able to change, and add checks in the backend which prevent erroneous changes from being applied

Comment 1 by valleau@chromium.org, May 9 2018

Labels: M-68
Project Member

Comment 2 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09

commit 4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09
Author: David Valleau <valleau@chromium.org>
Date: Mon May 14 19:56:31 2018

Changing edit_printer_dialog to prevent invalid printer configurations

Currently users are able to edit their printer's network configuration
in ways that would make the printer unusable. This change makes it so
that network printers cannot have their protocol changed to a
non-network protocol. Also, USB printers do not allow any changes to
their URI.

BUG= chromium:841053 
R=skau@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I74b6e50a09f1b61b7b63cf52f789a5d63d0d980d
Reviewed-on: https://chromium-review.googlesource.com/1053212
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558425}
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/app/settings_strings.grdp
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/chromeos/printing/printer_configurer.h
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/resources/settings/printing_page/cups_printers.js
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chromeos/printing/printer_configuration.cc
[modify] https://crrev.com/4041fe36745cd94b3f492c7fb3bcc7c1ad04ab09/chromeos/printing/printer_configuration.h

Comment 3 by valleau@chromium.org, May 17 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment