New issue
Advanced search Search tips

Issue 841026 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocked on:
issue 826380



Sign in to add a comment

Tabs no longer expand to touchable size when touched

Project Member Reported by jwer...@chromium.org, May 8 2018

Issue description

Chrome Version: Version 67.0.3396.26 (Official Build) beta (32-bit)
OS: Chrome OS Google_Kevin.8785.264.0

What steps will reproduce the problem?
(1) Get enough open tabs in a window so that they shrink to the minimum possible size (with barely enough space for the favicon, or an X to close if it's selected).
(2) Select a different tab by touching it with your finger.

What is the expected result?

Back before the R67 redesign, the tabs would expand to a larger minimum size to give you an easier target to touch (moving more tabs into the big condensed stash on the side to make room for a few larger tabs in the middle).

What happens instead?

Now after the redesign, they don't do that anymore. The UI difference between control-by-mouse and control-by-touch we used to have is gone.

I don't know if this is WAI. If it isn't, it's a regression that should be fixed. If it is, fair enough, but then I have a new usability issue with the new UI: the current tab always has the little X button to close it in place of the favicon, which is fine, but the problem is that this button seems to steal touch gestures from the tab. With any other tab, I can grab it and move it side-to-side to tug on the stash of condensed tabs on either side of the window, or I can long press it and then move it's position in the order of tabs around. I can no longer do that with the current tab, presumably because my swipe or long press action gets eaten by the X button (which doesn't know what to do with it) rather than the tab surface below it. This may have already been an issue before, but it wasn't a big deal in practice because due to the expanded touch targets the tabs were big enough that I could just grab them on a different spot that didn't have the X button over it. But since we removed the tab expansion, the tab is so tiny that the X button takes it up completely and there's no space left I can touch if I want to drag it around.
 
Owner: afakhry@chromium.org
->afakhry to triage
Cc: afakhry@chromium.org omrilio@chromium.org pkasting@chromium.org
Owner: malaykeshav@chromium.org
Status: Assigned (was: Untriaged)
Malay, can you please take a look?
Cc: sgabr...@chromium.org
This is WAI. The minimum width(~60px) does not change on touch. However, the minimum width was recently increased to 160px: Issue 826380

@pkasting @sgabriel - Do we want to merge that to M67?
Does the 160px tab offer enough of a touch target to easily drag or long-press the tab?

Even if it does, I think you might still want to consider fixing the drag/long-press when it hits the tab close button. Right now, that just does nothing, which is not very helpful. Even if only 30% (instead of 100%) of the tab is taken up by that button, it would still be nicer for the user if they haven't explicitly pay attention to avoiding it. I think this has always behaved that way but it becomes proportionally more of a problem the smaller the minimum tab size gets.
I think we should merge the min-width change to M67 -- it's super-safe.  I'm not sure what was causing the previous expansion -- it might actually have been the higher min width value, and merging this back will Just Fix the issue.

Reporter, if you are able to test this out on Canary and see if it's good enough, that would be a useful signal.
Blockedon: 826380
Status: Fixed (was: Assigned)

Sign in to add a comment