New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841019 link

Starred by 2 users
Status: Fixed
Owner:
osh...@chromium.org
Closed: May 2018
Cc:
omrilio@chromium.org
█ sashab@chromium.org
sammiequon@chromium.org
slangley@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

File Manager menu bar doesn't return when transitioning out of tablet mode

Project Member Reported by jwer...@chromium.org, May 8 2018 
Chrome Version: Version 67.0.3396.26 (Official Build) beta (32-bit)
OS: Chrome OS Google_Kevin.8785.264.0

What steps will reproduce the problem?
(1) Put your convertible in tablet mode
(2) Open File Manager
(3) Return the convertible to clamshell mode

What is the expected result?

The File Manager resizes back to a smaller window and gets its top menu bar (with the X on the right to close it, etc.) back.

What happens instead?

The File Manager resized back to a smaller window but it doesn't get its top menu bar back. There's also no surface I can grab to move the window around. I can still use the right (main) pane of the window without changing this, but as soon as I select a new folder on the left (sidebar) pane it refreshes and brings the menu bar back.

This is a new regression in R67.
Screenshot 2018-05-08 at 2.50.35 PM.png
260 KB View Download

Comment 1 by jwer...@chromium.org, May 8 2018

Components: UI>Shell>TouchView

Comment 2 by weifangsun@chromium.org, May 9 2018

Cc: slangley@chromium.org sashab@chromium.org omrilio@chromium.org
Labels: -M-67 M-68 OS-Chrome
Status: Available (was: Untriaged)
Also reproduced this on M67.

omrilio@ - Given this specific use case of switching back and forth between modes, would like to fix for M68 vs. trying to merge back to M67. Let me know if any concerns here.

Comment 3 by omrilio@chromium.org, May 16 2018

Labels: ReleaseBlock-Stable
Owner: sammiequon@chromium.org
Sammie, can you have a look?

Comment 4 by sammiequon@chromium.org, May 16 2018

Cc: sammiequon@chromium.org
Owner: osh...@chromium.org
+oshima

I bisected to:

https://chromium-review.googlesource.com/c/chromium/src/+/999967.

I couldn't actually build that version on my device because some other chrome issue cause crash before login or something, but I undid the changes in ash/frame/ locally and the title bar shows up.

Comment 5 by osh...@chromium.org, May 17 2018 

Looks like it just needs to re-layout upon state change. Can you confirm that switching window (say with alt-tab) fixes it?

Comment 6 by sammiequon@chromium.org, May 17 2018 

re#5 - confirmed that alt-tab or opening any window or changing activation fixes it.

Comment 7 by osh...@chromium.org, May 24 2018

Status: Fixed (was: Available)
This is fixed by https://chromium.googlesource.com/chromium/src.git/+/8184813eedd001e0397fd2dfce50f080cf3568d3.

I put wrong bug number, sorry.
Project Member

Comment 8 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, May 24 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 5

Labels: -Merge-TBD
►

Sign in to add a comment