New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841017 link

Starred by 1 user
Status: Fixed
Owner:
█ donnd@chromium.org
(OOO slow)
Closed: May 2018
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testTapGestureFollowedByScrollClearsSelection" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 8 2018 
"org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testTapGestureFollowedByScrollClearsSelection" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygQELEgVGbGFrZSJ2b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmNvbnRleHR1YWxzZWFyY2guQ29udGV4dHVhbFNlYXJjaE1hbmFnZXJUZXN0I3Rlc3RUYXBHZXN0dXJlRm9sbG93ZWRCeVNjcm9sbENsZWFyc1NlbGVjdGlvbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by vitaliii@chromium.org, May 9 2018 

Sample builds
https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/417418
https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/417206

the log is (repeated 3 times):
============
java.lang.AssertionError: Panel did not enter PEEKED state. Instead, the current state is UNDEFINED.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:93)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:172)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:194)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToEnterState(ContextualSearchManagerTest.java:807)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToPeek(ContextualSearchManagerTest.java:775)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.clickWordNode(ContextualSearchManagerTest.java:614)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testTapGestureFollowedByScrollClearsSelection(ContextualSearchManagerTest.java:1450)
	at java.lang.reflect.Method.invoke(Method.java)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:114)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:201)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:43)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:183)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:120)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
============

Comment 2 by vitaliii@chromium.org, May 9 2018

Components: UI>Browser>Search>ContextualSearch
Disabling the test in https://chromium-review.googlesource.com/c/chromium/src/+/1052129.

Comment 3 by vitaliii@chromium.org, May 9 2018

Cc: twelling...@chromium.org
Owner: donnd@chromium.org
Status: Assigned (was: Untriaged)
Adding donnd@ and twellington@ as OWNERS, could you have a look please?

Comment 4 by donnd@google.com, May 9 2018

Labels: OS-Android
Status: Started (was: Assigned)
Looks like it's pretty solid on K and L so I'll restrict to pre-M today.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testTapGestureFollowedByScrollClearsSelection
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/933195da3734a37d779b84f13efa39c759da24fb

commit 933195da3734a37d779b84f13efa39c759da24fb
Author: vitaliii <vitaliii@chromium.org>
Date: Wed May 09 15:51:48 2018

Disable flaky testTapGestureFollowedByScrollClearsSelection.

Disable org.chromium.chrome.browser.contextualsearch
ContextualSearchManagerTest
testTapGestureFollowedByScrollClearsSelection
because flaky.

TBR=donnd@chromium.org

Bug:  841017 
Change-Id: I0faca09f286ea776ce54d70c411ff61a7649132e
Reviewed-on: https://chromium-review.googlesource.com/1052129
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557197}
[modify] https://crrev.com/933195da3734a37d779b84f13efa39c759da24fb/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 6 by vitaliii@chromium.org, May 9 2018

Labels: -Sheriff-Chromium
Great, thank you for looking into this!
Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d588c7f2d687fe9fa8af2c610d7324cc468df181

commit d588c7f2d687fe9fa8af2c610d7324cc468df181
Author: Donn Denman <donnd@chromium.org>
Date: Fri May 11 16:56:13 2018

[TTS] Reenable a flaky test on some releases.

Reenables a test that was slightly flaky and disabled earlier today.
This test seems to be pretty solid on older builds of Android, so
enabling conditionally.

BUG= 841017 ,837996

Change-Id: I172a2c859d2a85d922319003a525d65fd44d01a5
Reviewed-on: https://chromium-review.googlesource.com/1053101
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557908}
[modify] https://crrev.com/d588c7f2d687fe9fa8af2c610d7324cc468df181/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 8 by donnd@chromium.org, May 11 2018

Status: Fixed (was: Started)
►

Sign in to add a comment