[about:flags] Chrome flags crash |
|||||
Issue description1. start Chrome, go to about:flags 2. change a flag 3. click Relaunch Now Problem: crashes: [135304:135362:0508/141852.454266:WARNING:x11_util.cc(1362)] X error received: serial 270, error_code 3 (BadWindow), request_code 4, minor_code 0 (Unknown) Received signal 11 SEGV_MAPERR 000000000000 #0 0x7fe1e375632c base::debug::StackTrace::StackTrace() #1 0x7fe1e3755e91 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fe1e37c10c0 <unknown> #3 0x7fe1e25d00f0 <unknown> #4 0x7fe1e121b638 content::(anonymous namespace)::SaveSessionStateOnIOThread() #5 0x7fe1e36a960c base::debug::TaskAnnotator::RunTask() #6 0x7fe1e36cb457 base::MessageLoop::RunTask() #7 0x7fe1e36cb9c7 base::MessageLoop::DoWork() #8 0x7fe1e3765ef9 base::MessagePumpLibevent::Run() #9 0x7fe1e36f17a5 base::RunLoop::Run() #10 0x7fe1e1229ad4 content::BrowserProcessSubThread::IOThreadRun() #11 0x7fe1e372292f base::Thread::ThreadMain() #12 0x7fe1e37640ad base::(anonymous namespace)::ThreadFunc() #13 0x7fe1e37b7494 start_thread #14 0x7fe1d89b2a8f clone r8: 0000000000000000 r9: 00000000000004da r10: 0022c85e0f0292a6 r11: 0000000000000000 r12: 000005a44d8ab78c r13: 00007fe1c77d78a0 r14: 000005a44dd6d800 r15: 00007fe1e378b290 di: 0000000000000000 si: 000005a44dd6d800 bp: 00007fe1c77d76e0 bx: 000005a44dc45700 dx: 00000000000000c0 ax: 000005a44de843c0 cx: 0000000000000000 sp: 00007fe1c77d76c8 ip: 00007fe1e25d00f0 efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated.
,
May 8 2018
,
May 8 2018
This hinders development, should it be a pri-0? I'm bisecting now, btw.
,
May 8 2018
I've found several flags to show the issue. I'm bisecting with #omnibox-new-answer-layout as my test (it just happens to be a flag I use a lot, no other reason to choose that one).
,
May 8 2018
Git bisect: bd3d1ea0e6c3f9450fb4fce34b06a64eab528ab7 is the first bad commit commit bd3d1ea0e6c3f9450fb4fce34b06a64eab528ab7 Author: Nick Harper <nharper@chromium.org> Date: Tue May 8 18:49:13 2018 +0000 Disable Channel ID on all platforms except Android Change-Id: I481ee17e83c2eef8433fa774285cf68e0b7c4ac8 Reviewed-on: https://chromium-review.googlesource.com/1041139 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556899} :040000 040000 af8852e93040e4050a2ec866890ebe3f744ee253 e4ef17f912fbaee70155ba4dc21dd76c3c91de1c M components
,
May 8 2018
,
May 8 2018
Reverted change for now: https://chromium-review.googlesource.com/c/chromium/src/+/1050646
,
May 8 2018
Changing priority since the change was reverted (well, I guess it's 'fixed', but I'll leave that choice to nharper@)
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ebf529cfab66f217371f992eddfb5865e7884f4 commit 7ebf529cfab66f217371f992eddfb5865e7884f4 Author: Nick Harper <nharper@chromium.org> Date: Wed May 09 20:35:03 2018 Revert "Revert "Disable Channel ID on all platforms except Android"" This reverts commit 3c79bfc0c46a9a5042351f2cae8d42e4e530ff3e. In addition to the original CL bd3d1ea, this includes a fix to the crash when relaunching after changing about:flags. Bug: 841006 Change-Id: I04c82074bb83da7ba5854b783862ec689d7a36e0 Reviewed-on: https://chromium-review.googlesource.com/1050976 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#557307} [modify] https://crrev.com/7ebf529cfab66f217371f992eddfb5865e7884f4/components/network_session_configurator/common/network_features.cc [modify] https://crrev.com/7ebf529cfab66f217371f992eddfb5865e7884f4/content/browser/browser_context.cc
,
May 9 2018
I think this is fixed now.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c114888ca8eea6f977bd7555e04b764833d8ea26 commit c114888ca8eea6f977bd7555e04b764833d8ea26 Author: Reid Kleckner <rnk@chromium.org> Date: Fri May 11 00:04:07 2018 Revert "Disable Channel ID on all platforms except Android" This reverts commit 7ebf529cfab66f217371f992eddfb5865e7884f4. Reason for revert: Breaks many browser_tests in official builds. Google-internal official builder: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/84099 Failures are visible publicly here: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1489 Original change's description: > Revert "Revert "Disable Channel ID on all platforms except Android"" > > This reverts commit 3c79bfc0c46a9a5042351f2cae8d42e4e530ff3e. > > In addition to the original CL bd3d1ea, this includes a fix to the crash > when relaunching after changing about:flags. > > Bug: 841006 > Change-Id: I04c82074bb83da7ba5854b783862ec689d7a36e0 > Reviewed-on: https://chromium-review.googlesource.com/1050976 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Nick Harper <nharper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557307} TBR=boliu@chromium.org,rch@chromium.org,nharper@chromium.org,dschuyler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 841006 Change-Id: I2900a883c01307f3c91bcd91698ef8487acfac44 Reviewed-on: https://chromium-review.googlesource.com/1054205 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557731} [modify] https://crrev.com/c114888ca8eea6f977bd7555e04b764833d8ea26/content/browser/browser_context.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dschuyler@chromium.org
, May 8 2018