New issue
Advanced search Search tips

Issue 841000 link

Starred by 2 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Oct 12
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Align webui test code style/formatting with webui "prod" code

Project Member Reported by dbeam@chromium.org, May 8 2018 
We've rarely held webui test code to the same standards as the "prod" code (that controls UI/logic shown to users).  This means less consistent code between 2 parts of the same codebase (that are often updated together in the same CL).  This also means having to manually format testing code (whereas prod code can benefit from things like `git cl format --js`).

Concretely: let's run clang-format on chrome/test/data/webui just like we have on chrome/browser/resources and enforce formatting through presubmit.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71d5be1f1631d489543f7bdb992fcaa0f7d26630

commit 71d5be1f1631d489543f7bdb992fcaa0f7d26630
Author: Dan Beam <dbeam@chromium.org>
Date: Fri May 11 00:33:48 2018

clang-format chrome/test/data/webui/settings; add presubmit to enforce

R=dpapad@chromium.org
BUG= 841000 

Change-Id: I4b0c6ae08a6097df28aed3743fbe82f211c2e023
Reviewed-on: https://chromium-review.googlesource.com/1053425
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557737}
[add] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/PRESUBMIT.py
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/a11y/settings_accessibility_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/about_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/advanced_page_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/android_apps_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/animation_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/appearance_fonts_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/appearance_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/basic_page_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/controlled_button_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/controlled_radio_button_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/cups_printer_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/date_time_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/display_size_slider_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/dropdown_menu_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/edit_dictionary_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/extension_controlled_indicator_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/fake_language_settings_private.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/fingerprint_progress_arc_browsertest_chromeos.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/import_data_dialog_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/internet_detail_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/internet_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/languages_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/languages_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/metrics_reporting_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/multidevice_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/on_startup_page_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/people_page_change_picture_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/people_page_manage_profile_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/people_page_sync_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/pref_util_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/prefs_test_cases.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/prefs_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/privacy_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/protocol_handlers_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/reset_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/reset_profile_banner_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/search_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/search_settings_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_animated_pages_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_idle_load_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_main_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_menu_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_page_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/settings_ui_browsertest.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/site_data_details_subpage_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/startup_urls_page_test.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/test_search_engines_browser_proxy.js
[modify] https://crrev.com/71d5be1f1631d489543f7bdb992fcaa0f7d26630/chrome/test/data/webui/settings/test_sync_browser_proxy.js
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17

commit bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17
Author: Dan Beam <dbeam@chromium.org>
Date: Wed May 16 03:38:25 2018

clang-format chrome/test/data/webui and enforce with presubmit

R=dpapad@chromium.org
BUG= 841000 

Change-Id: I883d939366572189204bd22c1dc076ef37d60fe0
Reviewed-on: https://chromium-review.googlesource.com/1058676
Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558959}
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/.eslintrc.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/PRESUBMIT.py
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/a11y/accessibility_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/about_invalidations_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/accessibility_audit_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/assertions.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/async_gen.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/bidichecker_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/bluetooth_internals_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/certificate_viewer_dialog_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/chrome_send_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/cr_elements/cr_drawer_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/cr_elements/cr_toggle_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/discards/discards_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/draganddroptoinput.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/a11y/extensions_a11y_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_detail_view_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_error_page_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_item_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_manager_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_manager_unit_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_navigation_helper_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_options_dialog_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_test_util.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_toolbar_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/extension_view_manager_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/extensions/toggle_row_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/inspect_ui_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/local_discovery_ui_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_bookmarks/list_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_bookmarks/policy_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_bookmarks/reducers_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_bookmarks/router_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_bookmarks/test_util.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_downloads/item_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_downloads/toolbar_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/history_item_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/history_metrics_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/history_routing_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/history_supervised_user_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/history_synced_tabs_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/history_toolbar_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/md_history_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/md_history_focus_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_history/test_util.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/md_user_manager/user_manager_pages_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/issue_banner_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_container_filter_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_container_first_run_flow_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_container_route_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_container_search_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_container_sink_list_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_container_test_base.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_elements_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_header_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/media_router_search_highlighter_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/route_controls_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/media_router/route_details_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/mocha_adapter.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/mock_controller.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/mock_timer.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/bandwidth_view.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/chromeos_view.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/dns_view.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/domain_security_policy_view.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/events_view.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/log_util.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/log_view_painter.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/net_internals_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/prerender_view.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/net_internals/timeline_view.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/ntp4.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/password_manager_internals_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/polymer_browser_test_base.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/cloud_print_interface_stub.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/custom_margins_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/destination_dialog_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/destination_search_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/destination_select_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/model_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/print_preview_test_utils.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/settings_select_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/print_preview/system_dialog_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/profile_window_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/sandboxstatus_browsertest.js
[delete] https://crrev.com/a81e00522e161fd7f9c495ac1ea4792aef3f3eee/chrome/test/data/webui/settings/PRESUBMIT.py
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/signin/sync_confirmation_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/sys_internals/sys_internals_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/test_api.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/test_browser_proxy.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/webui_resource_async_browsertest.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/webview_content_script_test.js
[modify] https://crrev.com/bf5a9a200a61ad6c0c2ed30011d144a3b6bc9a17/chrome/test/data/webui/webview_execute_script.js

Comment 3 by dbeam@chromium.org, Oct 12

Owner: dbeam@chromium.org
Status: Fixed (was: Available)
sure, we can call this done for now.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9303a066683e170516f039010569ba093f0e47b4

commit 9303a066683e170516f039010569ba093f0e47b4
Author: Nasko Oskov <nasko@chromium.org>
Date: Mon Oct 15 18:03:44 2018

clang-format JavaScript files in content/browser/resources/.

JavaScript files for WebUI pages in chrome/ already are subject to
clang-format, ESLint, and other checkers. This CL is changing all
JS files in content/browser/resources/ to be clang-format'd, so a
PRESUBMIT rule can be put in place to enforce proper formatting in
future commits.

PRESUBMIT.py will come separately as part of work to make the
process-internals WebUI clang-format and eslint checked in
https://chromium-review.googlesource.com/c/chromium/src/+/1268658.

Bug:  841000 
Change-Id: I22ee7649b3d524d68c5cb2b39a53f057150b181c
Reviewed-on: https://chromium-review.googlesource.com/c/1279178
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599681}
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/appcache/appcache_internals.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/gpu/browser_bridge.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/gpu/browser_bridge_tests.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/gpu/info_view.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/indexed_db/indexeddb_internals.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/client_renderer.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/dump_creator.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/main.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/manager.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/peer_connection_update_table.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/ssrc_info_manager.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/stats_graph_helper.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/stats_table.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/timeline_graph_view.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/util.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/media/webrtc_internals.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/net/network_errors_listing.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/process/process_internals.js
[modify] https://crrev.com/9303a066683e170516f039010569ba093f0e47b4/content/browser/resources/service_worker/serviceworker_internals.js
►

Sign in to add a comment