Issue metadata
Sign in to add a comment
|
TextOffsetMapping make blink::SlotAssignment::Trace() to crash |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5725509091328000 Fuzzer: inferno_layout_test_unmodified Job Type: linux_tsan_chrome_mp Platform Id: linux Crash Type: UNKNOWN READ Crash Address: 0x0000023d77c0 Crash State: blink::SlotAssignment::Trace blink::TraceTrait<blink::SlotAssignment>::Trace blink::ScriptWrappable::Wrap Sanitizer: thread (TSAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=550101:550107 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5725509091328000 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
May 8 2018
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/1324be868df000cb2e070199ce2d10cd0c5a2706 (Make NextWordPosition() to utilize TextOffsetMapping). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
May 9 2018
,
May 9 2018
,
May 9 2018
,
May 9 2018
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2018
,
May 9 2018
+awhalley@ (Security TPM) for triage.
,
May 10 2018
,
May 10 2018
ClusterFuzz has detected this issue as fixed in range 557407:557410. Detailed report: https://clusterfuzz.com/testcase?key=5725509091328000 Fuzzer: inferno_layout_test_unmodified Job Type: linux_tsan_chrome_mp Platform Id: linux Crash Type: UNKNOWN READ Crash Address: 0x0000023d77c0 Crash State: blink::SlotAssignment::Trace blink::TraceTrait<blink::SlotAssignment>::Trace blink::ScriptWrappable::Wrap Sanitizer: thread (TSAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=550101:550107 Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=557407:557410 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5725509091328000 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
May 10 2018
ClusterFuzz testcase 5725509091328000 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
May 10 2018
,
May 15 2018
requesting merge of https://chromium.googlesource.com/chromium/src.git/+/4c414662683ec6083af7de599683c7fc177dc5d6 per comment 9
,
May 15 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2018
+awhalley@ for M67 merge review
,
May 15 2018
govind@ - good for 67
,
May 15 2018
Approving merge for cl listed at #13 to M67 branch 3396 based on comment #16. Pls merge now so we can take it in for tomorrow's beta release. Thank you.
,
May 15 2018
AFAIK there is no need to merge to M67, as the culprit patch is already reverted there: Revert "Make NextWordPosition() to utilize TextOffsetMapping" This reverts commit 1324be868df000cb2e070199ce2d10cd0c5a2706 for M67/Beta TextOffsetMapping is not ready for release. It should support edge cases. TBR=yosin@chromium.org Bug: 832055 , 832061 , 832101 , 832261 , 832350 , 832497 , 832639 , 833172 , 833180 Change-Id: Iac5f58716619a626650088a55109922daf1a4f3a Reviewed-on: https://chromium-review.googlesource.com/1013445 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#36} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} It seems that ClusterFuzz calculates the impacted branches from revision numbers on trunk, instead of testing the actual branches
,
May 15 2018
Thanks xiaochengh@ - yep, confirmed by code inspection.
,
May 15 2018
>#c7, this is already reverted on M67 on April 17 by http://crrev.com/c/1013445
,
Aug 16
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ClusterFuzz
, May 8 2018Labels: Test-Predator-Auto-Components