An empty config from the DRP config server should be treated as valid |
||
Issue descriptionCurrently if the DRP config server sends a configuration without any proxies in it, it is treated as a fetch failure. We should make it be treated as valid so empty configs can be sent if we want to https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc?rcl=42995a35d04a84eafe12fc4b3f13e7dd15fec4a7&l=562
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4832621e94544200deda95f4f9ed5b3792b4e98b commit 4832621e94544200deda95f4f9ed5b3792b4e98b Author: Robert Ogden <robertogden@chromium.org> Date: Wed May 09 16:58:20 2018 Don't retry an empty proxy config This allows the config server to send an empty config in order to effectivly turn off DataSaver if needed. Bug: 840978 Change-Id: I7b5e57728737401c286da29ccbd7cc4564c73732 Reviewed-on: https://chromium-review.googlesource.com/1050805 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#557221} [modify] https://crrev.com/4832621e94544200deda95f4f9ed5b3792b4e98b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc [modify] https://crrev.com/4832621e94544200deda95f4f9ed5b3792b4e98b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
,
May 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by robertogden@chromium.org
, May 8 2018