New issue
Advanced search Search tips

Issue 840964 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

smoothness.tough_animation_cases/web_animations_many_keyframes.html?N=0316 in smoothness.tough_animation_cases failing on chromium.perf/Android Nexus5 Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 8 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

smoothness.tough_animation_cases/web_animations_many_keyframes.html?N=0316 in smoothness.tough_animation_cases failing on chromium.perf/Android Nexus5 Perf

Builders failed on: 
- Android Nexus5 Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5%20Perf

Looks like this story has been flaky on and off for a while now, but it's hard to tell whether this is a new issue or random chance made it so that the issue didn't arise for a while.

Going to launch a bisect between what looks like healthier days and now and see if it turns up anything. In the meanwhile, I'm going to disable this story.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/550542eea0f82476ce4ea089f9e39821c1955234

commit 550542eea0f82476ce4ea089f9e39821c1955234
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue May 08 20:18:50 2018

Disable flaky tough_animation_cases story

NOTRY=true
TBR=nednguyen@chromium.org

Bug:  840964 
Change-Id: I6e06540a2e893878a66c06690b2a007aaeee1831
Reviewed-on: https://chromium-review.googlesource.com/1050395
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556941}
[modify] https://crrev.com/550542eea0f82476ce4ea089f9e39821c1955234/tools/perf/expectations.config

Components: Blink>Animation
Status: Untriaged (was: Available)
Labels: -Pri-1 Pri-2
Owner: charliea@chromium.org
Status: Assigned (was: Untriaged)
Hi Charlie, could you update the thread once there's any update from the bisect? Thanks!
Sigh, it looks like I really botched this one up:

- It was originally failing on Nexus 5 Perf, not Nexus 5X Perf. I disabled it on the wrong platform.
- I never launched the bisect to identify the problem. There may have been a reason for this, or I may have just gotten distracted in the middle of the process of launching it.

Regardless, the story is passing consistently on ToT Nexus 5, so I'm going to revert the disable and close this bug.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=smoothness.tough_animation_cases&tests=smoothness.tough_animation_cases%2Fweb_animations_many_keyframes.html%3FN%3D0316


Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da7712974b07208f63583494a37d457526c60fd9

commit da7712974b07208f63583494a37d457526c60fd9
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue May 29 17:09:17 2018

Revert "Disable flaky tough_animation_cases story"

This reverts commit 550542eea0f82476ce4ea089f9e39821c1955234.

Reason for revert: I disabled the story on the wrong platform and it's no longer even failing on the platform I meant to disable it on.

Original change's description:
> Disable flaky tough_animation_cases story
> 
> NOTRY=true
> TBR=nednguyen@chromium.org
> 
> Bug:  840964 
> Change-Id: I6e06540a2e893878a66c06690b2a007aaeee1831
> Reviewed-on: https://chromium-review.googlesource.com/1050395
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Commit-Queue: Charlie Andrews <charliea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556941}

NOTRY=true
TBR=nednguyen@google.com,charliea@chromium.org
Bug:  840964 

Change-Id: Ibf83faf0ccf87ec4ae95232cfa5e1f11b76f0cf4
Reviewed-on: https://chromium-review.googlesource.com/1076807
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562469}
[modify] https://crrev.com/da7712974b07208f63583494a37d457526c60fd9/tools/perf/expectations.config

Status: Fixed (was: Assigned)

Sign in to add a comment