dut-control: ec_uart_parity: cannot marshall None |
||||
Issue descriptionOn Scarlet, with ToT hdctools: $ dut-control --port=9992 ec_uart_parity Problem with ['ec_uart_parity'] :: cannot marshal None unless allow_none is enabled I'm quite sure this is a recent regression.
,
May 8 2018
Reverting that patch works, as does applying a hack like this:
diff --git a/servo/system_config.py b/servo/system_config.py
index 2c9cbd1f042a..b10ff4b751aa 100644
--- a/servo/system_config.py
+++ b/servo/system_config.py
@@ -441,6 +441,8 @@ class SystemConfig(object):
SystemConfigError: errors using formatting param
"""
if 'map' not in params and 'fmt' not in params:
+ if value is None:
+ return "None"
return value
reformat_value = str(value)
if 'map' in params:
I'm not sure what the right way to unwind this is.
,
May 8 2018
on tot with soraka and dru I get none instead of None as my output. Is this using dut-control, or using some of the autotest xmlrpc proxies? I noticed that some of our xmlrpc proxies have allow_none=True not set (in autotest for instance) so that might be causing issues. I'll add a CL to mitigate the None for now, but I'd want to make sure we can get rid of that special case
,
May 9 2018
dut-control, as the $subject says
,
May 9 2018
What servo device are you using? micro, ccd, v2?
,
May 9 2018
CCD (servo v4). Sorry, forgot to note that
,
May 9 2018
And BTW, I don't see how Cr50 could every provide a non-None parity: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/master/servo/drv/cr50.py#67 if not hasattr(self._interface, '_ec_uart_bitbang_props'): self._interface._ec_uart_bitbang_props = { 'enabled': False, 'parity': None, 'baudrate': None }
,
May 9 2018
,
May 9 2018
crrev.com/c/1051148 for the parity issue crrev.com/c/1051147 to disallow none return types
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/b5fe0f1391d8d19f9788e38bd96c337677ef666d commit b5fe0f1391d8d19f9788e38bd96c337677ef666d Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Date: Fri May 11 06:18:03 2018 sysconfig: don't allow raw None return Even though we have allow_none=True specified, there's still issues with None values across xmlrpc. Disallow None return by casting it to a string (as done previously). BUG=chromium:840961 BUG=chromium:841097 TEST=manual test cr50 ccd servod dut-control -p $PORT ec_uart_parity ec_uart_parity:None Change-Id: I505cdaf47dd04db60970743588aec654efce2c3e Reviewed-on: https://chromium-review.googlesource.com/1051147 Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> [modify] https://crrev.com/b5fe0f1391d8d19f9788e38bd96c337677ef666d/servo/servo_server.py [modify] https://crrev.com/b5fe0f1391d8d19f9788e38bd96c337677ef666d/servo/system_config.py
,
Jun 23 2018
Is this bug done? I still see this outstanding: https://chromium-review.googlesource.com/c/chromiumos/third_party/hdctools/+/1051148 |
||||
►
Sign in to add a comment |
||||
Comment 1 by briannorris@chromium.org
, May 8 2018