ffmpeg configure doesn't detect inline asm support |
|||
Issue description
in ffmpeg upstream commit 8c893aa3cd5, configure quit adding quotes around inline asm in source files. clang gets mad. this patch fixes it:
diff --git a/configure b/configure
index 3f30a20667..d9b084adf4 100755
--- a/configure
+++ b/configure
@@ -1036,7 +1036,7 @@ EOF
check_insn(){
log check_insn "$@"
- check_inline_asm ${1}_inline "$2"
+ check_inline_asm ${1}_inline "\"$2\""
check_as ${1}_external "$2"
}
,
May 8 2018
+1
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/fcf9829a54fd01b936ce1979ff91057c38a0f640 commit fcf9829a54fd01b936ce1979ff91057c38a0f640 Author: liberato@chromium.org <liberato@chromium.org> Date: Tue May 08 20:28:52 2018 Replace required quotes in check_insn clang fails to notice inline asm support without quoting the insn in the source, failing with: check_insn armv5te qadd r0, r0, r0 .../test.c:1:34: error: expected string literal in 'asm' void foo(void){ __asm__ volatile(qadd r0, r0, r0); } The correct code, produced by this CL, is: void foo(void){ __asm__ volatile("qadd r0, r0, r0"); } Bug: 840959 Change-Id: Ibed36978d0b141c7d3369956ab2cf78c0a8c2a88 Reviewed-on: https://chromium-review.googlesource.com/1050727 Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> [modify] https://crrev.com/fcf9829a54fd01b936ce1979ff91057c38a0f640/configure [modify] https://crrev.com/fcf9829a54fd01b936ce1979ff91057c38a0f640/chromium/patches/README
,
May 18 2018
,
May 30 2018
submitted this to upstream. |
|||
►
Sign in to add a comment |
|||
Comment 1 by liber...@chromium.org
, May 8 2018