New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840952 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 739532



Sign in to add a comment

OOBE WebUI needs to migrate from <content> to <slot>

Project Member Reported by dpa...@chromium.org, May 8 2018

Issue description

The following files still use the old <content> syntax (alse see [1])

controller-pairing-screen.html
oobe_a11y_option.html
gaia_card.html
notification_card.html
gaia_buttons.html
gaia_input_form.html
host-pairing-screen.html
oobe_dialog.html
oobe_buttons.html

These need to be migrated to <slot> to unblock the WebUI's migration to Polymer 2.

[1] https://cs.chromium.org/search/?q=%22%3Ccontent%22+file:%5Esrc/chrome/browser/resources/chromeos/login/+package:%5Echromium$&type=cs

 
Blocking: 739532
Cc: kochi@chromium.org
Labels: -Pri-3 Pri-2
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b

commit 8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jun 15 21:57:54 2018

ChromeOS OOBE: Migrate templates from <content> to <slot>

Bug:  840952 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I58379298fe27ccebb75c043a1e1bd507efeb6baa
Reviewed-on: https://chromium-review.googlesource.com/1080798
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567806}
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/active_directory_password_change.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/arc_terms_of_service.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/controller_pairing_page.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/demo_setup.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/encryption_migration.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/encryption_migration.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/enrollment_license_card.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/gaia_buttons.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/gaia_card.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/gaia_card.html
[add] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/gaia_card_parameters.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/gaia_input_form.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/gaia_input_form.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/notification_card.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_dialog.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_dialog_parameters.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_hid_detection.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_reset.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_reset_confirmation_overlay.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_reset_confirmation_overlay.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_screen_controller_pairing.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_text_button.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_wait_for_container_ready.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_welcome.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/recommend_apps.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/recommend_apps.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/saml_interstitial.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/screen_sync_consent.html
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/sync_consent.css
[modify] https://crrev.com/8ee28d2aa698ea46e9c5ab08cb7abbf9f6524f0b/chrome/browser/resources/chromeos/login/sync_consent.html

Owner: alemate@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment