New issue
Advanced search Search tips

Issue 840934 link

Starred by 1 user
Status: Fixed
Owner:
altimin@chromium.org
Closed: May 2018
Cc:
hajimehoshi@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Comment on LocalFrame::GetFrameScheduler seems inaccurate

Project Member Reported by dcheng@chromium.org, May 8 2018 
The comment says:

  // Returns the frame scheduler, creating one if needed.

We should update this to describe what actually happens (and it would also be useful for Page::GetPageScheduler to document when it can return null).
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b393426db382219f520317fc49c5705a1da9fa7

commit 3b393426db382219f520317fc49c5705a1da9fa7
Author: Alexander Timin <altimin@chromium.org>
Date: Fri May 18 11:43:21 2018

[blink] Update LocalFrame::GetFrameScheduler comment

R=dcheng@chromium.org,hajimehoshi@chromium.org
BUG= 840934 

Change-Id: Id3b0e9ac257f1bc104ff035cbe42e23fdaaa8b66
Reviewed-on: https://chromium-review.googlesource.com/1064351
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559864}
[modify] https://crrev.com/3b393426db382219f520317fc49c5705a1da9fa7/third_party/blink/renderer/core/frame/local_frame.h

Comment 2 by dcheng@chromium.org, May 21 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment