New issue
Advanced search Search tips

Issue 840898 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 831852



Sign in to add a comment

Update extensions developer mode toolbar for MD Refresh.

Project Member Reported by dpa...@chromium.org, May 8 2018

Issue description

Blocking: 831852
Components: UI>Browser>ExtensionsManagement
Cc: aee@chromium.org

Comment 3 by aee@chromium.org, May 9 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 4 by aee@chromium.org, May 9 2018

Screen Shot 2018-05-09 at 2.21.35 PM.png
262 KB View Download

Comment 5 by aee@chromium.org, May 9 2018

Status: Started (was: Assigned)
Cc: rdevlin....@chromium.org

Comment 7 by aee@chromium.org, May 10 2018

Attaching a screenshot showing the focused state of a button in the dev-mode button strip.
Screen Shot 2018-05-10 at 12.46.21 PM.png
221 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0884a2c6a68829fdb63261916c9239c3ff3cab87

commit 0884a2c6a68829fdb63261916c9239c3ff3cab87
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu May 10 23:28:00 2018

MD Extensions: dev-mode toolbar MD refresh

Bug:  840898 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5180a32f2453547d915ca5867190facc30e63e00
Reviewed-on: https://chromium-review.googlesource.com/1053115
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557721}
[modify] https://crrev.com/0884a2c6a68829fdb63261916c9239c3ff3cab87/chrome/browser/resources/md_extensions/toolbar.html

Comment 10 by aee@chromium.org, May 10 2018

Status: Fixed (was: Started)
Cc: pnangunoori@chromium.org
Labels: TE-Verified-68.0.3427.0 TE-Verified-M68
Verified the fix on Windows-10, Mac 10.13.3 and Debian Rodete on Chrome version #68.0.3427.0 as per the comment#0 and mocks.

Attaching screenshot for reference. Observed that tool bar is updated in chrome://extensions in developer mode for MD and button in the focused state. Hence, the fix is working as expected and adding the TE-Verified labels.

Thanks!
840898.png
164 KB View Download

Sign in to add a comment