New issue
Advanced search Search tips

Issue 840893 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 803548



Sign in to add a comment

right click context menu shows up in the wrong coordinate space for Viz hit-test + OOP-D

Project Member Reported by riajiang@chromium.org, May 8 2018

Issue description

right click context menu position is not transformed correctly in Viz hit-test when OOP-D is enabled
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7225465e622041cbd36406749c9690afe4de1f8a

commit 7225465e622041cbd36406749c9690afe4de1f8a
Author: Ria Jiang <riajiang@chromium.org>
Date: Thu May 10 23:53:33 2018

Skip LocalSurfaceId validation in TransformPoint* for Viz hit-test.

Viz hit-test doesn't need LocalSurfaceId in targeting/ transforming
requests, HitTestQuery has that information; and we don't currently
have a valid one in RenderWidgetHostViewGuest and
RenderWidgetHostViewChildFrame in OOP-D. We could add it in RWHVG/
RWHVCF, but since we don't need it anyway, skip this validation for
Viz hit-test.

Bug:  840893 
Change-Id: Ic9bbf9f29fc2016f9c838f781f8cf554c180d61e
Reviewed-on: https://chromium-review.googlesource.com/1050440
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557725}
[modify] https://crrev.com/7225465e622041cbd36406749c9690afe4de1f8a/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/7225465e622041cbd36406749c9690afe4de1f8a/content/browser/renderer_host/render_widget_host_view_child_frame.cc

Status: Fixed (was: Started)

Sign in to add a comment