After quickly exiting WebXR presentation, Omnibox is hidden |
||||||||||||
Issue descriptionChrome Version: 68.0.3420.1 OS: Android L Device: LG G3 What steps will reproduce the problem? (1) Enable WebXR (2) Go to https://immersive-web.github.io/webxr-samples/360-photos.html (3) Press enter VR button (4) Swipe in from screen to press system back button or x to exit presentation. (5) Repeatedly enter and exit presentation. (A few times should repro the issue) What is the expected result? After exiting presentation, Omnibox should always appear. What happens instead? Omnibox is hidden after exiting presentation 1/3 times. See screenshot.
,
May 24 2018
David, can you please verify that this bug is either fixed or still reproducible? I don't have an LG G3 to test with.
,
May 24 2018
,
May 24 2018
,
May 24 2018
Hi Michael, I can repro it but only if I exit the presentation very quickly after entering. If I wait a few seconds, I can't repro it. 68.0.3439.0
,
May 24 2018
,
May 24 2018
It also repros on a Pixel device. And it's easy to repro with cardboard as the headset by using the x to close immediately after entering the presentation. It's possible to repro also with Daydream as the headset but much more difficult. I had to be really fast at hitting the x button. (Sorry, I should have checked this when I first logged the bug.)
,
May 24 2018
This is pretty much certainly in M67 as well but at this point it's too late to do anything about it. I'll see if I can come up with a less flaky fix for controls hiding.
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1920a358f0797dc61fdc1c48041715339c02a900 commit 1920a358f0797dc61fdc1c48041715339c02a900 Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri May 25 16:44:54 2018 VR: Don't animate control container. It seems like the races between the hiding propagating and us showing the controls goes away when we turn off animations. I don't remember why we originally had to animate the controls, but I think whatever problems that was working around have since been fixed. Bug: 840891 Change-Id: I5420ba311c82ef284514667d5c8eb66b9e387654 Reviewed-on: https://chromium-review.googlesource.com/1072735 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#561910} [modify] https://crrev.com/1920a358f0797dc61fdc1c48041715339c02a900/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
May 25 2018
,
May 25 2018
Note that this was also possible with a WebVR site.
,
May 28 2018
Couldn't repro on Canary anymore. Appears to be fixed.
,
May 28 2018
,
May 29 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c6e95c8e12d9857e4c57ab3229a266aba987bd4 commit 1c6e95c8e12d9857e4c57ab3229a266aba987bd4 Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue May 29 15:33:30 2018 VR: Don't animate control container. It seems like the races between the hiding propagating and us showing the controls goes away when we turn off animations. I don't remember why we originally had to animate the controls, but I think whatever problems that was working around have since been fixed. TBR=mthiesse@chromium.org (cherry picked from commit 1920a358f0797dc61fdc1c48041715339c02a900) Bug: 840891 Change-Id: I5420ba311c82ef284514667d5c8eb66b9e387654 Reviewed-on: https://chromium-review.googlesource.com/1072735 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561910} Reviewed-on: https://chromium-review.googlesource.com/1076320 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#20} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/1c6e95c8e12d9857e4c57ab3229a266aba987bd4/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
May 29 2018
,
Jun 26 2018
Verified in Chrome Beta 68.0.3440.39
,
Jun 26 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by cjgrant@chromium.org
, May 18 2018Owner: mthiesse@chromium.org
Status: Assigned (was: Untriaged)