New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840889 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Picture-in-picture interferes with screensaver suppression

Project Member Reported by markdavidscott@google.com, May 8 2018

Issue description

Chrome 68.0.3424.0 on Windows 10 Professional.

Watching the I/O keynote (https://www.youtube.com/watch?v=ogfYd705cRs), I used the PIP API via Chrome devtools to pop things out into a PIP window.  However, I in this mode screensaver suppression seems to be turned off; if I just focus on the video and stop touching my keyboard/mouse, my screensaver eventually kicks in.
 
Components: -Blink>Media>Controls Blink>Media>PictureInPicture
Owner: apaci...@chromium.org
Cc: mlamouri@chromium.org
Cc: -mlamouri@chromium.org apaci...@chromium.org
Owner: mlamouri@chromium.org
Status: Assigned (was: Untriaged)
Per offline discussion, mlamouri will be taking a look.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10c6fad6cf53f11ee5f6de4e65be75fd08ef033d

commit 10c6fad6cf53f11ee5f6de4e65be75fd08ef033d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon May 21 22:11:34 2018

Picture-in-Picture: keep video wake lock for PIP video in background tab.

Refactors logic to keep video wake lock to more easily integrates PIP
videos.

Bug:  840889 
Change-Id: I2e0e7c922a1416159d7622fe8b71048fe28afb65
Reviewed-on: https://chromium-review.googlesource.com/1063085
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560372}
[modify] https://crrev.com/10c6fad6cf53f11ee5f6de4e65be75fd08ef033d/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/10c6fad6cf53f11ee5f6de4e65be75fd08ef033d/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/10c6fad6cf53f11ee5f6de4e65be75fd08ef033d/content/browser/web_contents/web_contents_impl_unittest.cc

Labels: M-68
Status: Fixed (was: Started)

Sign in to add a comment