Issue metadata
Sign in to add a comment
|
"org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting_WebXr__CustomTabActivity" is flaky |
||||||||||||||||||||||||
Issue description"org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting_WebXr__CustomTabActivity" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyhAELEgVGbGFrZSJ5b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLnZyX3NoZWxsLldlYlZyVHJhbnNpdGlvblRlc3QjdGVzdFdpbmRvd1JhZlN0b3BzRmlyaW5nV2hpbGVQcmVzZW50aW5nX1dlYlhyX19DdXN0b21UYWJBY3Rpdml0eQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs This flaky test/step was previously tracked in issue 818841 .
,
May 9 2018
Issue 840908 has been merged into this issue.
,
May 9 2018
,
May 9 2018
The CL disabling the test is https://chromium-review.googlesource.com/c/chromium/src/+/1051788.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e079f1560454dfe7b2a19d10527d963583c48acb commit e079f1560454dfe7b2a19d10527d963583c48acb Author: vitaliii <vitaliii@chromium.org> Date: Wed May 09 15:23:10 2018 Disable flaky testWindowRafStopsFiringWhilePresenting_WebXr. Disable org.chromium.chrome.browser.vr_shell.WebVrTransitionTest testWindowRafStopsFiringWhilePresenting_WebXr because flaky. TBR=bsheedy@chromium.org Bug: 840883 Change-Id: I2300a6be8d79d1d6f47d33d5fd06edc9fee5ca41 Reviewed-on: https://chromium-review.googlesource.com/1051788 Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557189} [modify] https://crrev.com/e079f1560454dfe7b2a19d10527d963583c48acb/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
,
May 9 2018
,
May 9 2018
Detected 8 new flakes for test/step "org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting_WebXr__ChromeTabbedActivity". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyhwELEgVGbGFrZSJ8b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLnZyX3NoZWxsLldlYlZyVHJhbnNpdGlvblRlc3QjdGVzdFdpbmRvd1JhZlN0b3BzRmlyaW5nV2hpbGVQcmVzZW50aW5nX1dlYlhyX19DaHJvbWVUYWJiZWRBY3Rpdml0eQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
May 9 2018
Detected 6 new flakes for test/step "org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting_WebXr__WebappActivity". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygQELEgVGbGFrZSJ2b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLnZyX3NoZWxsLldlYlZyVHJhbnNpdGlvblRlc3QjdGVzdFdpbmRvd1JhZlN0b3BzRmlyaW5nV2hpbGVQcmVzZW50aW5nX1dlYlhyX19XZWJhcHBBY3Rpdml0eQw. This message was posted automatically by the chromium-try-flakes app.
,
May 9 2018
Assigning to bajones@ as the WebXR guy, but feel free to re-assign.
,
May 9 2018
Detected 3 new flakes for test/step "org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting_WebXr__CustomTabActivity". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyhAELEgVGbGFrZSJ5b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLnZyX3NoZWxsLldlYlZyVHJhbnNpdGlvblRlc3QjdGVzdFdpbmRvd1JhZlN0b3BzRmlyaW5nV2hpbGVQcmVzZW50aW5nX1dlYlhyX19DdXN0b21UYWJBY3Rpdml0eQw. This message was posted automatically by the chromium-try-flakes app.
,
May 10 2018
Looking at the logs, seeing the same root cause as issue 840638 . This has been fixed. Reverting the test-disables.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d947f01d7b93529012262b90db89aa9b75674b53 commit d947f01d7b93529012262b90db89aa9b75674b53 Author: Eric Karl <ericrk@chromium.org> Date: Thu May 10 22:24:06 2018 Revert "Disable flaky testWindowRafStopsFiringWhilePresenting_WebXr." This reverts commit e079f1560454dfe7b2a19d10527d963583c48acb. Reason for revert: These flakes are addressed with https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659 Original change's description: > Disable flaky testWindowRafStopsFiringWhilePresenting_WebXr. > > Disable org.chromium.chrome.browser.vr_shell.WebVrTransitionTest > testWindowRafStopsFiringWhilePresenting_WebXr because flaky. > > TBR=bsheedy@chromium.org > > Bug: 840883 > Change-Id: I2300a6be8d79d1d6f47d33d5fd06edc9fee5ca41 > Reviewed-on: https://chromium-review.googlesource.com/1051788 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557189} TBR=bsheedy@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 840883 Change-Id: I7638d3489db017dc040683e8a6cc6ce47c2df94d Reviewed-on: https://chromium-review.googlesource.com/1054352 Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#557697} [modify] https://crrev.com/d947f01d7b93529012262b90db89aa9b75674b53/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by vitaliii@chromium.org
, May 9 2018