New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

SysmonMetricsMissing on chromeos4-devserver5

Project Member Reported by nxia@chromium.org, May 8 2018

Issue description

DEBUG:chromite.scripts.sysmon.loop:Sleeping for 60, 60 remaining
ERROR:chromite.scripts.sysmon.loop:Error during loop.
Traceback (most recent call last):
  File "/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/loop.py", line 34, in loop_once
    self._callback()
  File "/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/mainlib.py", line 52, in __call__
    net_metrics.collect_net_info()
  File "/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/net_metrics.py", line 52, in collect_net_info
    _collect_net_io_duplex_counters()
  File "/home/chromeos-test/chromiumos/chromite/venv/chromite/scripts/sysmon/net_metrics.py", line 88, in _collect_net_io_duplex_counters
    except metrics.MonitoringDecreasingValueError as ex:
AttributeError: 'module' object has no attribute 'MonitoringDecreasingValueError'
DEBUG:chromite.scripts.sysmon.loop:Sleeping for 60, 60 remaining

 

Comment 1 by nxia@chromium.org, May 8 2018

The error is gone after I restarted sysmon
Status: WontFix (was: Untriaged)
Okay, that's weird.  Sounds like the metrics module lost its MonitoringDecreasingValueError

wontfix unless we see it again

Comment 3 by nxia@chromium.org, May 8 2018

Status: Available (was: WontFix)
This happened before and was resolved by restart. I took a look, turns out metrics doesn't have MonitoringDecreasingValueError, it needs to be "metrics.ts_mon.common.errors.MonitoringDecreasingValueError" instead.

Comment 4 by nxia@chromium.org, May 8 2018

Cc: ayatane@chromium.org

Comment 5 by nxia@chromium.org, May 8 2018

Components: -Infra>Client>ChromeOS>Test Infra>Client>ChromeOS>CI

Comment 6 by nxia@chromium.org, May 8 2018

Cc: nxia@chromium.org
Owner: ----

Comment 7 by nxia@chromium.org, May 8 2018

Owner: la...@chromium.org
Owner: ayatane@chromium.org
Status: Assigned (was: Available)
Oops, i can fix it
Project Member

Comment 9 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/071969702e6dbe0d4433093726acd6a0add55518

commit 071969702e6dbe0d4433093726acd6a0add55518
Author: Allen Li <ayatane@chromium.org>
Date: Wed May 09 08:11:01 2018

sysmon: Fix error reference

BUG= chromium:840873 
TEST=Run sysmon for a few ticks

Change-Id: I9882e753abbf4996a97959e26061b857ff6e50d4
Reviewed-on: https://chromium-review.googlesource.com/1050408
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/071969702e6dbe0d4433093726acd6a0add55518/scripts/sysmon/net_metrics.py

Project Member

Comment 10 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4434e5d6a2fabb9754d7aaf4cca155daba3b65

commit 7e4434e5d6a2fabb9754d7aaf4cca155daba3b65
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 09 10:30:45 2018

Roll src/third_party/chromite/ 9520b5b98..7aaefdbb7 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9520b5b98bd3..7aaefdbb734f

$ git log 9520b5b98..7aaefdbb7 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 cmtice Re-enable CFI on caroline and terra release builders.
2018-05-08 ayatane sysmon: Fix error reference

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:838428 , chromium:840873 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If6a4c93d5ee5c6ce8af44cb19895b5ce12b72dcb
Reviewed-on: https://chromium-review.googlesource.com/1051325
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557138}
[modify] https://crrev.com/7e4434e5d6a2fabb9754d7aaf4cca155daba3b65/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment