New issue
Advanced search Search tips

Issue 840871 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 831883



Sign in to add a comment

Need dialog announcements and button labels on the power off / sign out UI

Project Member Reported by lpalmaro@chromium.org, May 8 2018

Issue description

OS: Chrome
Canary

- Turn on ChromeVox, Ctrl Alt Z
- Longpress the power button and open the UI that has the 2 buttons: Power off and Sign out

Nothing is verbalized. Then if you press Search + Right, or Tab, you just hear "Button, press Search + Space to activate"

What should happen: 
1. When that UI appears, we should announce that this has appeared. We should say something like -- "Power off options" or something like that to tell the user this has happened. 
2. We need labels on these buttons so they verbalize what they are actually for. 

Video of the experience: 
https://photos.app.goo.gl/Ysk0lk7DwgnR66xG3
 
@Zach/Albert, can you please help to triage? 
 

Comment 1 by katie@chromium.org, May 8 2018

Cc: minch@chromium.org
+minch as this looks related to recent changes in ash/system/power/power_button_menu_view.h?
Blocking: 831883

Comment 3 by minch@chromium.org, May 9 2018

Still not quite clean about the label that we want to add for the menu.

1. When the menu is shown, the focus is on "power off" item. What should be verbalized in this case? sth like "Power button menu, power off item is selected. Press ESC, touch or click screen to dismiss"? since focus is on "power off" item.

2. For pressing tab or direction keys (left/right/top/bottom) to change the focus, just verbalize the label of the item, "power off" or "sign out" separately?

Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7930731aa6b3283118fc66df5a331c414acacfa

commit b7930731aa6b3283118fc66df5a331c414acacfa
Author: Min Chen <minch@google.com>
Date: Wed May 23 19:35:32 2018

Add chromevox text for power button menu.

Bug:  840871 , 831883
Change-Id: Icaa856e75ad1f0c09640a1ba045d0c7ede28f25e
Reviewed-on: https://chromium-review.googlesource.com/1064479
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561206}
[modify] https://crrev.com/b7930731aa6b3283118fc66df5a331c414acacfa/ash/ash_strings.grd
[modify] https://crrev.com/b7930731aa6b3283118fc66df5a331c414acacfa/ash/system/power/power_button_menu_item_view.cc
[modify] https://crrev.com/b7930731aa6b3283118fc66df5a331c414acacfa/ash/system/power/power_button_menu_view.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/352bf3b8f23199b00e931babfc1768a7d1ae058b

commit 352bf3b8f23199b00e931babfc1768a7d1ae058b
Author: Min Chen <minch@google.com>
Date: Tue May 29 17:54:36 2018

[Merge to M67]Add chromevox text for power button menu.

TBR=minch@chromium.org

(cherry picked from commit b7930731aa6b3283118fc66df5a331c414acacfa)

Bug:  840871 , 831883
Change-Id: Icaa856e75ad1f0c09640a1ba045d0c7ede28f25e
Reviewed-on: https://chromium-review.googlesource.com/1064479
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561206}
Reviewed-on: https://chromium-review.googlesource.com/1076887
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#712}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/352bf3b8f23199b00e931babfc1768a7d1ae058b/ash/system/power/power_button_menu_item_view.cc
[modify] https://crrev.com/352bf3b8f23199b00e931babfc1768a7d1ae058b/ash/system/power/power_button_menu_view.cc

Comment 6 by minch@chromium.org, May 29 2018

Status: Fixed (was: Available)

Sign in to add a comment