New issue
Advanced search Search tips

Issue 840853 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

internal refactoring: decompose model.py, service.py and swarming.py

Project Member Reported by no...@chromium.org, May 8 2018

Issue description

buildbucket's model.py, service.py and swarming.py are large files with too much responsibilities.

Decompose them into smaller files with less responsibilities.
 

Comment 1 by no...@chromium.org, May 8 2018

Blocking: -832733
Labels: buildbucket-go
Too hard, I'd rather reimplement this in Go
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/99fa41f5395f64cff4ac2de348e79cf49a7ce66b

commit 99fa41f5395f64cff4ac2de348e79cf49a7ce66b
Author: Nodir Turakulov <nodir@google.com>
Date: Thu May 17 15:12:07 2018

[buildbucket] add buildtags.py

Move all build tags related functions and globals to buildtags.py.
Update the rest of the code.

Pure refactoring. No functional changes.

Bug: 840853
Change-Id: I63e90eebfd503cc00070e887e9bd1b3253df1035
Reviewed-on: https://chromium-review.googlesource.com/1062498
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/test/service_test.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/v2/api.py
[add] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/test/buildtags_test.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/v2/test/api_test.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/service.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/metrics.py
[add] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/buildtags.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/v2/builds.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/99fa41f5395f64cff4ac2de348e79cf49a7ce66b/appengine/cr-buildbucket/model.py

Comment 3 by no...@chromium.org, May 19 2018

Owner: ----
Status: Available (was: Started)

Comment 4 by no...@chromium.org, Jun 16 2018

Labels: -Pri-1 Pri-2
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 20 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8c3bc760c43930c867638648281adf8cf22ceb43

commit 8c3bc760c43930c867638648281adf8cf22ceb43
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Jun 21 00:49:01 2018

[buildbucket] Add search.py

Move search-related code from monolithic service.py and model.py to search.py,
including two search implementations and TagIndex data models.
No functional changes.

Bug:  854484 , 840853
Change-Id: If83db1b82c82ed9d4fa84d1d67da42974f579105
Reviewed-on: https://chromium-review.googlesource.com/1108566
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/handlers.py
[add] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/search.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/handlers_test.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/service_test.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/v2/api.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/api_test.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/v2/test/api_test.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/service.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/model_test.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/api.py
[add] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/search_test.py
[modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/model.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2018

Sign in to add a comment