cache-keys-attributes-for-service-worker layout test can cause test flakiness |
|||
Issue descriptioncache-keys-attributes-for-service-worker creates a cache named 'foo' (https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/resources/cache-keys-attributes-for-service-worker.js?l=14), and cache-storage-match expects that 'foo' doesn't exist (https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-storage-match.js?l=120). Depending on the order these layout tests are run, cache-storage-match will fail.
,
Jun 28 2018
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e631b9e13e7939dcb74801667c4609c1b56f30e2 commit e631b9e13e7939dcb74801667c4609c1b56f30e2 Author: Joshua Bell <jsbell@chromium.org> Date: Tue Jul 03 15:38:26 2018 Deflake cache-storage/script-tests/cache-storage-match.js WPT The test assumed no cache named 'foo' existed, but another test cache-keys-attributes-for-service-worker creates a cache by that name, so the test would flakily fail in some runs depending on the ordering of the tests. Make the test defensive by deleting such a cache before proceeding. Bug: 840850 Change-Id: Ia349706c9a32af309cfadf9a63ba5cffea11998d Reviewed-on: https://chromium-review.googlesource.com/1119104 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#572232} [modify] https://crrev.com/e631b9e13e7939dcb74801667c4609c1b56f30e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/script-tests/cache-storage-match.js
,
Jul 3
Fixed, I hope? |
|||
►
Sign in to add a comment |
|||
Comment 1 by jsb...@chromium.org
, May 11 2018Status: Available (was: Untriaged)