New issue
Advanced search Search tips

Issue 840848 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 738794
issue 825890



Sign in to add a comment

Move ViewportDescriptor out of core/dom

Project Member Reported by beccahughes@chromium.org, May 8 2018

Issue description

After https://crrev.com/c/1047946 has landed move ViewportDescriptor out of core/dom
 
Blocking: 738794
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f30113c2b68ec7ce23d4ad1826095836de4252df

commit f30113c2b68ec7ce23d4ad1826095836de4252df
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jun 04 17:26:28 2018

[Refactor] Move ViewportDescriptor out of core/dom

As discussed in https://crrev.com/c/1047946, moving
ViewportDescriptor into core/page instead of core/dom.

BUG= 840848 

Change-Id: I79041b65ae4778b54b94fada465d52ad6888b62c
Reviewed-on: https://chromium-review.googlesource.com/1083771
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564135}
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.cc
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/css/resolver/viewport_style_resolver.h
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/css/style_engine_test.cc
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/dom/BUILD.gn
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/frame/page_scale_constraints_set.h
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/html/html_meta_element.h
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/html/parser/html_preload_scanner.h
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/page/BUILD.gn
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/page/page.h
[rename] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/page/viewport_description.cc
[rename] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/page/viewport_description.h
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/page/viewport_test.cc
[modify] https://crrev.com/f30113c2b68ec7ce23d4ad1826095836de4252df/third_party/blink/renderer/core/testing/internals.cc

Status: Fixed (was: Started)

Sign in to add a comment