Issue metadata
Sign in to add a comment
|
[VR Browsing] default media controls button hover UI doesn't have rounded corners |
||||||||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3420.1 OS: Android N Device: Pixel XL What steps will reproduce the problem? (1) enter VR browsing (2) go to m.youtube.com (3) play a video and click on the fullscreen button (4) Hover over the mute or the menu buttons What is the expected result? The hover over state should be a square with rounded corners. What happens instead? The top two corners of the hover-over UI are squared. See screenshot.
,
May 16 2018
This is marked as Bug-Regression. Is this something that used to work, and if so, do you have a working chrome version #? Also, all corners should be rounded, so this is a bug. Thanks for filing
,
May 16 2018
Actually, don't worry about it since I figured out a fix anyway
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19826a6a2971b87b9379006f382d9995c245db4c commit 19826a6a2971b87b9379006f382d9995c245db4c Author: Tommy Steimel <steimel@chromium.org> Date: Mon May 21 21:55:47 2018 [Media Controls VR] Increase specificity for VR CSS rules This CL increases the specificity for the VR CSS changes for the media controls. This fixes an issue where some of the CSS rules were being overridden by more specific (but non-VR rules). Bug: 840839 Change-Id: I62504e5bc23af6c73c888ad9bcada3d525752746 Reviewed-on: https://chromium-review.googlesource.com/1062767 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#560360} [modify] https://crrev.com/19826a6a2971b87b9379006f382d9995c245db4c/third_party/WebKit/LayoutTests/media/controls/modern/immersive-mode-adds-css-class.html [modify] https://crrev.com/19826a6a2971b87b9379006f382d9995c245db4c/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/19826a6a2971b87b9379006f382d9995c245db4c/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
,
May 21 2018
|
|||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||
Comment 1 by cjgrant@chromium.org
, May 16 2018Status: Assigned (was: Untriaged)