Text Input not working |
||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1) Navigate to https://chromeperf.appspot.com/report (2) Click the "Test suit" text input (3) Type something What is the expected result? Text shows up. What happens instead? It doesnt :) Local bisection result: You are probably looking for a change made after 554677 (known good), but no later than 554678 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/0219ebefc1b05c41be9a4e109a14a013ebedbc2d..17005ce5a2e98caed08193844f33e71496dd84ea 17005ce [Squad] Remove unnecessary user-modify update. by Rune Lillesveen ยท 9 days ago
,
May 9 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19a2e6ea00f954d7c5691d2b0033f8227cca9a1c commit 19a2e6ea00f954d7c5691d2b0033f8227cca9a1c Author: Rune Lillesveen <futhark@chromium.org> Date: Thu May 10 09:15:56 2018 Make sure readonly and disabled are applied to inner editor. -webkit-user-modify is not set on the input element by disabled or readonly attributes, but on the inner editor based on the input attributes. The style recalc is triggered from StyleDidChange on LayoutTextControl for the input element. However, if the input element style does not change StyleDidChange is not called, and the inner editor style is not updated. Trigger the style update when readonly and disabled attributes change. Bug: 840833 Change-Id: Iad291b0a079efd197074366e127d1aa3a1f757e7 Reviewed-on: https://chromium-review.googlesource.com/1051236 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#557480} [modify] https://crrev.com/19a2e6ea00f954d7c5691d2b0033f8227cca9a1c/third_party/blink/renderer/core/html/forms/text_control_element_test.cc [modify] https://crrev.com/19a2e6ea00f954d7c5691d2b0033f8227cca9a1c/third_party/blink/renderer/core/html/forms/text_field_input_type.cc [modify] https://crrev.com/19a2e6ea00f954d7c5691d2b0033f8227cca9a1c/third_party/blink/renderer/core/html/forms/text_field_input_type.h
,
May 10 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by futhark@chromium.org
, May 8 2018