[UI Refresh] Fullscreen is disabled for pages with mixed SSL content |
||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): M67 iOS Version: All Device: All Steps to reproduce: 1.) Enable UI refresh flag 2.) Load a long web page with mixed SSL content (https page with http images) 3.) Scroll the page to enter Fullscreen Observed behavior: The toolbar stays in place Expected behavior: The app should go Fullscreen
,
May 8 2018
,
May 8 2018
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6123a89c7f9d01db2d4ab0cf011d37b1bf33b294 commit 6123a89c7f9d01db2d4ab0cf011d37b1bf33b294 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue May 08 16:39:13 2018 [iOS] Don't disable fullscreen for SSL with UI refresh enabled. The omnibox and its security indicator remains on screen even when in fullscreen mode, so there is no longer a need to disable fullscreen for the UI refresh. Bug: 840828 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5eb89f2992fec399287807d77089a34af88d141c Reviewed-on: https://chromium-review.googlesource.com/1050376 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556830} [modify] https://crrev.com/6123a89c7f9d01db2d4ab0cf011d37b1bf33b294/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm [modify] https://crrev.com/6123a89c7f9d01db2d4ab0cf011d37b1bf33b294/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer_unittest.mm
,
May 8 2018
,
Aug 23
Verified on chrome beta version 69.0.3497.58 on iPhone 8 plus and iPad 2018 with iOS 11.4.1. Web page with mixed SSL content goes full screen. Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by eugene...@chromium.org
, May 8 2018