Try to use a unified libc++ everywhere |
||||||
Issue descriptionLinux has been using a statically linked, bundled libc++ for a while. We used to use a statically-linked libc++ on Mac until https://codereview.chromium.org/2314753002/ undid that. We probably want to statically link libc++ again, but using the Linux setup with a source-built libc++. bug 767901 already exists for android to switch from ndk libc++ to bundled libc++. bug 801780 is the same for windows. (CEF at least will also want to keep supporting msvc stdlib though.) (cros uses its own custom thing; iOS uses iOS system libc++. might be ok to keep those as is for now, or maybe we want to change at least iOS to statically linked as well.) Advantages are less platform variation (e.g. for bug 752720).
,
May 8 2018
,
May 9 2018
,
Jun 4 2018
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 15
,
Jan 17
(5 days ago)
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9d71d7e9f8ebd301d9a6449adfef44e63a65487 commit d9d71d7e9f8ebd301d9a6449adfef44e63a65487 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jan 18 17:58:26 2019 Switch Mac to in-tree libc++ builds Binary size regression of up to 512KiB is expected. buildtools roll includes a single CL: https://chromium.googlesource.com/chromium/buildtools/+/2f02e1f363b1af2715536f38e239853f04ec1497 Note on chromium-dev: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/QeXzX4MVrlo BUG=840822, 923084 R=thakis TBR=kbr Change-Id: Iacaf90dc480c6d8b9939c99c398a8960a2e9d4ed Reviewed-on: https://chromium-review.googlesource.com/c/1396842 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#624193} [modify] https://crrev.com/d9d71d7e9f8ebd301d9a6449adfef44e63a65487/DEPS [modify] https://crrev.com/d9d71d7e9f8ebd301d9a6449adfef44e63a65487/build/config/c++/c++.gni [modify] https://crrev.com/d9d71d7e9f8ebd301d9a6449adfef44e63a65487/build/config/mac/BUILD.gn [modify] https://crrev.com/d9d71d7e9f8ebd301d9a6449adfef44e63a65487/headless/BUILD.gn [modify] https://crrev.com/d9d71d7e9f8ebd301d9a6449adfef44e63a65487/testing/scripts/check_static_initializers.py |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by thakis@chromium.org
, May 8 2018