New issue
Advanced search Search tips

Issue 840796 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
M-X



Sign in to add a comment

Focus rings are incompatible with grid layout

Project Member Reported by lgrey@chromium.org, May 8 2018

Issue description

Calling "FocusRing::Install" on a view that uses a grid layout manager DCHECKs because grid layout expects to manage all subviews of the view.
 
Cc: -ellyjo...@chromium.org lgrey@chromium.org
Labels: MacViews-Cleanup M-X
Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)
I think the right path forward here is for FocusRing to not be a View, since FocusRing doesn't fit into the LayoutManager model (in which a LayoutManager is expected to lay out all children of a View) at all. Perhaps we need to introduce a new ancillary concept ("Decoration"?) which has no independent layout, can't receive events, can't have children, &c &c but is just invoked during view painting. I'll take this one on.
Labels: Group-Focus_Input_Selection_Activation_KeyState
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
**UI mass Triage**

Adding labels for expert review.

Sign in to add a comment