New issue
Advanced search Search tips

Issue 840792 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

external/.../pointerevent_touch-action-table-test_touch-manual.html in webkit_layout_tests Flaky on chromium.mac/Mac10.12 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 8 2018

Issue description

Labels: -Sheriff-Chromium
Owner: nzolghadr@chromium.org
Status: Assigned (was: Available)
nzolghadr@chromium.org: Assigning to you since you are listed as owner. Please reassign to a better owner if necessary.
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/362667ffae6cebab49444fca6fcd1556b5106259

commit 362667ffae6cebab49444fca6fcd1556b5106259
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue May 08 13:51:03 2018

Mark pointerevent_touch-action-table-test_touch-manual.html as Flaky on Mac10.12

NOTRY=true
TBR=nzolghadr@chromium.org

Bug:  840792 
Change-Id: I4032cd2ec67b7158ce650927f7d78594ce09c4b2
Reviewed-on: https://chromium-review.googlesource.com/1049972
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556782}
[modify] https://crrev.com/362667ffae6cebab49444fca6fcd1556b5106259/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd6696e0288ac9f7ef9633c2710dab6ddf7acfa2

commit dd6696e0288ac9f7ef9633c2710dab6ddf7acfa2
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue May 08 14:20:33 2018

Update pointerevent_touch-action-table-test_touch-manual.html flaky expectations

NOTRY=true
TBR=nzolghadr@chromium.org

Bug:  840792 
Change-Id: I3b952baa48fc0280120abb61b73eb6eab2863a70
Reviewed-on: https://chromium-review.googlesource.com/1050225
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556790}
[modify] https://crrev.com/dd6696e0288ac9f7ef9633c2710dab6ddf7acfa2/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by tkent@chromium.org, Jun 4 2018

Components: Blink>Input
Cc: nzolghadr@chromium.org
Labels: -Pri-2 Pri-3
Owner: eirage@chromium.org
Ella, do you think there is anything special about this test or in general about the way we enabled touch tests on Mac? Would you be able to take a look whenever you get a chance?
Looks like the test is timeout because slow instead of error. I tested it locally with 500 runs, it didn't timeout but running slowly.
And the slowness doesn't looks like causing by the way we injecting touch events. (inject each event causes <1 ms)
There is a place which we mark some tests as slow so the script gives it more time. Do you want to mark this test as such?
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8cd8cb89ff6e2ca428a54a697166237b2f50d5d

commit d8cd8cb89ff6e2ca428a54a697166237b2f50d5d
Author: Ella Ge <eirage@chromium.org>
Date: Thu Jun 07 12:58:22 2018

Mark pointerevent_touch-action-table-test_touch-manual.html slow

Test pointerevent_touch-action-table-test_touch-manual.html time out
at 6s on mac bot. Mark it as slow test instead.

Bug:  840792 
Change-Id: Ib95bb311902aa7b3371af736035dd4d80831efe6
Reviewed-on: https://chromium-review.googlesource.com/1089531
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565245}
[modify] https://crrev.com/d8cd8cb89ff6e2ca428a54a697166237b2f50d5d/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/d8cd8cb89ff6e2ca428a54a697166237b2f50d5d/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)
The test sometimes time out at 6s on mac trybot, see the flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fpointerevents%2Fpointerevent_touch-action-table-test_touch-manual.html
The test's automation has a 4-second delay promise, it may be easy to run out 6 seconds.

Furthermore, test pointerevent_touch-action-span-test_touch-manual.html has the same automation but didn't timeout. so touch injection is not likely the cause the timeout.

This test is marked as slow now. 

Sign in to add a comment