Statistics should be held consistent across GC cycles and there should be a single source of truth. This source of truth should then be used for - chrome://tracing - histograms - printing - heuristics
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/756e029cb110f6a7ad99316e2c0fe77f8aa63cce commit 756e029cb110f6a7ad99316e2c0fe77f8aa63cce Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue May 08 18:27:56 2018 [oilpan] Add heap stats collection mechanism This CL introduces HeapTracer which a single concept to track interesting garbage collection numbers across garbage collections. This allows for unit testing measurements and unifying the histogram logic into a single place. Bug: chromium:840789 Change-Id: Ie36d6f9cc973f0dec28a3305b2d0def59bafe135 Reviewed-on: https://chromium-review.googlesource.com/1046647 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556885} [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/BUILD.gn [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/blink_gc.h [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/heap_page.cc [add] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [add] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/heap_stats_collector.h [add] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/heap_test.cc [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/thread_state.cc [modify] https://crrev.com/756e029cb110f6a7ad99316e2c0fe77f8aa63cce/third_party/blink/renderer/platform/heap/thread_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6ff060cc760c7cb8a44be7314ce5e96757213c6 commit c6ff060cc760c7cb8a44be7314ce5e96757213c6 Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon May 14 23:23:14 2018 [oilpan] Cleanup tracing scopes - Use ThreadHeapStatsCollector scopes instead of manual scopes - Allow adding parameters - Allow enabling by default - Fix telemetry unit tests Bug: chromium:840789, chromium:757440 Change-Id: If291b08d989d11233a31a4fbfc28db0b2f594e2b Reviewed-on: https://chromium-review.googlesource.com/1057626 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558522} [modify] https://crrev.com/c6ff060cc760c7cb8a44be7314ce5e96757213c6/third_party/blink/renderer/platform/heap/heap_page.cc [modify] https://crrev.com/c6ff060cc760c7cb8a44be7314ce5e96757213c6/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [modify] https://crrev.com/c6ff060cc760c7cb8a44be7314ce5e96757213c6/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/c6ff060cc760c7cb8a44be7314ce5e96757213c6/third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc [modify] https://crrev.com/c6ff060cc760c7cb8a44be7314ce5e96757213c6/third_party/blink/renderer/platform/heap/thread_state.cc [modify] https://crrev.com/c6ff060cc760c7cb8a44be7314ce5e96757213c6/tools/perf/contrib/oilpan/oilpan_gc_times.py [modify] https://crrev.com/c6ff060cc760c7cb8a44be7314ce5e96757213c6/tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47c443d999d64a5311cdf8c290c7f8cc876dbe6a commit 47c443d999d64a5311cdf8c290c7f8cc876dbe6a Author: Keishi Hattori <keishi@chromium.org> Date: Mon May 21 06:12:32 2018 Oilpan: End traces when only the blink_gc category is enabled Fixes issue where Oilpan traces would not be closed when only the blink_gc category is enabled. (regressed in r558522) Bug: 840789 Change-Id: Ie6e005e88b05db592f47655966ddff3fd8bf65c8 Reviewed-on: https://chromium-review.googlesource.com/1065723 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#560237} [modify] https://crrev.com/47c443d999d64a5311cdf8c290c7f8cc876dbe6a/third_party/blink/renderer/platform/heap/heap_stats_collector.h
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/8fbdf9f10b76595b6299e577709f2608ae29e19a commit 8fbdf9f10b76595b6299e577709f2608ae29e19a Author: Michael Lippautz <mlippautz@chromium.org> Date: Wed May 30 00:17:37 2018 Fix blink-gc metrics Bug: chromium:840789 Change-Id: I320bc87c1031b1027dbd68e8996fd6c8364913fd Reviewed-on: https://chromium-review.googlesource.com/1075885 Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> [modify] https://crrev.com/8fbdf9f10b76595b6299e577709f2608ae29e19a/tracing/tracing/metrics/blink/gc_metric.html [modify] https://crrev.com/8fbdf9f10b76595b6299e577709f2608ae29e19a/tracing/tracing/metrics/blink/gc_metric_test.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b21ce4491830ae04afcf2612638db875b9b5972d commit b21ce4491830ae04afcf2612638db875b9b5972d Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 30 02:11:59 2018 Roll src/third_party/catapult 53a5cc3..8fbdf9f (2 commits) https://chromium.googlesource.com/catapult.git/+log/53a5cc3..8fbdf9f git log 53a5cc3..8fbdf9f --date=short --no-merges --format='%ad %ae %s' 2018-05-29 mlippautz@chromium.org Fix blink-gc metrics 2018-05-25 dtu@chromium.org [pinpoint] Support other Telemetry targets for perf tryjobs. Created with: gclient setdep -r src/third_party/catapult@8fbdf9f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:840789 TBR=sullivan@chromium.org Change-Id: I779f379ecd41013e2352113c4dfb17504b3fa5fd Reviewed-on: https://chromium-review.googlesource.com/1077674 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562695} [modify] https://crrev.com/b21ce4491830ae04afcf2612638db875b9b5972d/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d65711abd8a70a1d463da429c5dbffa1d3b759f0 commit d65711abd8a70a1d463da429c5dbffa1d3b759f0 Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Jun 01 06:04:07 2018 [oilpan] Move compaction stats to stats collector Bug: chromium:840789 Change-Id: I888c722bc8af6547c57212f4f46634b58511214c Reviewed-on: https://chromium-review.googlesource.com/1081781 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#563546} [modify] https://crrev.com/d65711abd8a70a1d463da429c5dbffa1d3b759f0/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/d65711abd8a70a1d463da429c5dbffa1d3b759f0/third_party/blink/renderer/platform/heap/heap_compact.cc [modify] https://crrev.com/d65711abd8a70a1d463da429c5dbffa1d3b759f0/third_party/blink/renderer/platform/heap/heap_compact.h [modify] https://crrev.com/d65711abd8a70a1d463da429c5dbffa1d3b759f0/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [modify] https://crrev.com/d65711abd8a70a1d463da429c5dbffa1d3b759f0/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/d65711abd8a70a1d463da429c5dbffa1d3b759f0/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ece6c20a8c693873db956685c76f4d9dbf75ec88 commit ece6c20a8c693873db956685c76f4d9dbf75ec88 Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Jun 01 08:25:22 2018 [oilpan] Fix scopes across marking phase Each subphase gets its own scope for tracking performance. Bug: chromium:840789 Change-Id: I2dc22983a29ef48edf6174cb478fedf2ed5bf8af Reviewed-on: https://chromium-review.googlesource.com/1082174 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#563563} [modify] https://crrev.com/ece6c20a8c693873db956685c76f4d9dbf75ec88/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/ece6c20a8c693873db956685c76f4d9dbf75ec88/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/ece6c20a8c693873db956685c76f4d9dbf75ec88/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdd98637aba24a7fcaabea785e85252419e4d7a3 commit fdd98637aba24a7fcaabea785e85252419e4d7a3 Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Jun 05 02:40:05 2018 [oilpan] Update collection rate histograms for all GC reasons Bug: chromium:840789, chromium:757440 Change-Id: I9841524427dcb072ece75888f928b3e09bbf368c Reviewed-on: https://chromium-review.googlesource.com/1086430 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564353} [modify] https://crrev.com/fdd98637aba24a7fcaabea785e85252419e4d7a3/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3860f3e4d199e934052b3486a226dde44fb22e9a commit 3860f3e4d199e934052b3486a226dde44fb22e9a Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Jun 05 05:11:12 2018 [oilpan] Use atomic phase marking time for BlinkGC.CollectGarbage The histogram will be deprecated soon. Up until then it should use the atomic phase marking time though and not the sum of all marking time. No-try: true Bug: chromium:840789, chromium:757440 Change-Id: Ic425ba4538ec7d32b4055f9f5c905d387711a637 Reviewed-on: https://chromium-review.googlesource.com/1086559 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564362} [modify] https://crrev.com/3860f3e4d199e934052b3486a226dde44fb22e9a/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d58b508a28d4b5beb82e6931a2b78080900d32fc commit d58b508a28d4b5beb82e6931a2b78080900d32fc Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Jun 05 05:21:12 2018 [oilpan] Update GC reason in stats collection This reason is reported to UMA. No-try: true Bug: chromium:840789, chromium:757440 Change-Id: Ie2000aa96b34e13e8280b08c7e7c7931f3efe216 Reviewed-on: https://chromium-review.googlesource.com/1086428 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564364} [modify] https://crrev.com/d58b508a28d4b5beb82e6931a2b78080900d32fc/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [modify] https://crrev.com/d58b508a28d4b5beb82e6931a2b78080900d32fc/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/d58b508a28d4b5beb82e6931a2b78080900d32fc/third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc [modify] https://crrev.com/d58b508a28d4b5beb82e6931a2b78080900d32fc/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09f81d9f83fc84bf05fabc870a57d3451dc88590 commit 09f81d9f83fc84bf05fabc870a57d3451dc88590 Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Jun 05 08:45:00 2018 [oilpan] Add new BlinkGC UMA counters Histgram CL: https://chromium-review.googlesource.com/c/chromium/src/+/1086432 Bug: chromium:840789, chromium:757440 Change-Id: Ie2b3510ac774ba8ac66ee9f11dc8aa8dd22ac677 Reviewed-on: https://chromium-review.googlesource.com/1086809 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564411} [modify] https://crrev.com/09f81d9f83fc84bf05fabc870a57d3451dc88590/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a59e82d42cc4a866e2f5a94e6c4e93df277315d9 commit a59e82d42cc4a866e2f5a94e6c4e93df277315d9 Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Jun 05 11:57:26 2018 [oilpan] More uses of stats collector Convert over the remaining use cases of raw TRACE_EVENT macros. Bug: chromium:840789 Change-Id: Id1938b1382a6549552e7637577cc5833d95bc4f0 Reviewed-on: https://chromium-review.googlesource.com/1086947 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564456} [modify] https://crrev.com/a59e82d42cc4a866e2f5a94e6c4e93df277315d9/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/a59e82d42cc4a866e2f5a94e6c4e93df277315d9/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/a59e82d42cc4a866e2f5a94e6c4e93df277315d9/third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc [modify] https://crrev.com/a59e82d42cc4a866e2f5a94e6c4e93df277315d9/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0 commit a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0 Author: Michael Lippautz <mlippautz@chromium.org> Date: Wed Jun 06 12:45:42 2018 [oilpan] Move stats from ThreadHeapStats to ThreadHeapStatsCollector - Add unit tests. - Move more UMA histograms into common bottleneck. Bug: chromium:840789 Change-Id: Ia51a60cb424fe29eb5f4590f58f5454daf16b6bb Reviewed-on: https://chromium-review.googlesource.com/1082133 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564867} [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/heap_page.cc [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/heap_test.cc [modify] https://crrev.com/a28edd7823a5e5d6c3f524c9e5b6202b0ff655f0/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a198bd391edea387150f5040c4bdf78e683faa6 commit 2a198bd391edea387150f5040c4bdf78e683faa6 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Jun 07 00:36:04 2018 histograms: Update BlinkGC histograms - Fix labels of GCReason suffixes - Deprecate BlinkGC.CollectGarbage in favor of more exact buckets. See histograms.xml - Introduce BlinkGC.AtomicPhaseMarking for the atomic marking phase - Apply suffixes to interesting buckets to get exact pause times per GC reason No-try: true Bug: chromium:840789, chromium:757440 , chromium:847735 Change-Id: I611fea498c925c70286e44d10a885aa769552bcb Reviewed-on: https://chromium-review.googlesource.com/1086432 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565123} [modify] https://crrev.com/2a198bd391edea387150f5040c4bdf78e683faa6/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62969da11ca06e8404cad0dc24d6555fbe82950f commit 62969da11ca06e8404cad0dc24d6555fbe82950f Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Jun 07 10:41:56 2018 [oilpan] Move tracer counters into PostSweep Bug: chromium:840789 Change-Id: Idb0fc0e67a1a5d08acca9cad5c310bf9a370a965 Reviewed-on: https://chromium-review.googlesource.com/1090415 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565222} [modify] https://crrev.com/62969da11ca06e8404cad0dc24d6555fbe82950f/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/62969da11ca06e8404cad0dc24d6555fbe82950f/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89e4972ca8aaa2eafd82a42947de96ad7c9d9707 commit 89e4972ca8aaa2eafd82a42947de96ad7c9d9707 Author: Daniel Bratell <bratell@opera.com> Date: Thu Jun 07 16:29:34 2018 Move duplicate CappedSizeInKB() to header file for sharing Some jumbo builds broke because of too many CappedSizeInKB so moving it to heap.h to unbreak the builds. It's a small inlined method. The moved function is not using std::min to avoid including <algorithm> in heap.h and potentially causing a measurable build time regression. TBR=mlippautz@chromium.org,haraken@chromium.org Bug: 840789 Change-Id: I4e4bf3989235c6e7274a56f5c10823d8bb37a4df Reviewed-on: https://chromium-review.googlesource.com/1090839 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#565289} [modify] https://crrev.com/89e4972ca8aaa2eafd82a42947de96ad7c9d9707/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/89e4972ca8aaa2eafd82a42947de96ad7c9d9707/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/89e4972ca8aaa2eafd82a42947de96ad7c9d9707/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81e4119e85b2681ba9438e962ecb1d80eb958e8d commit 81e4119e85b2681ba9438e962ecb1d80eb958e8d Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Jun 08 05:41:35 2018 [oilpan] Move allocated space to ThreadHeapStatsCollector Bug: chromium:840789 Change-Id: Ic73ce15ac2057d4ed6fec89d3fc74c8bf32909ae Reviewed-on: https://chromium-review.googlesource.com/1092210 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565557} [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/heap_page.cc [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/heap_test.cc [modify] https://crrev.com/81e4119e85b2681ba9438e962ecb1d80eb958e8d/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeb22d12973cf64797be317fbe789eaf8ba55960 commit aeb22d12973cf64797be317fbe789eaf8ba55960 Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Jun 08 08:37:45 2018 [oilpan] Move partition alloc counters to ThreadHeapStatsCollector Bug: chromium:840789 Change-Id: I03c307038cb5c2a6bdea1d821e347128e5368125 Reviewed-on: https://chromium-review.googlesource.com/1092216 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565589} [modify] https://crrev.com/aeb22d12973cf64797be317fbe789eaf8ba55960/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/aeb22d12973cf64797be317fbe789eaf8ba55960/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/aeb22d12973cf64797be317fbe789eaf8ba55960/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [modify] https://crrev.com/aeb22d12973cf64797be317fbe789eaf8ba55960/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/aeb22d12973cf64797be317fbe789eaf8ba55960/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32c61869c629d800bd3e91fe9f7656aec93b425c commit 32c61869c629d800bd3e91fe9f7656aec93b425c Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Jun 08 23:59:26 2018 [oilpan] Move wrapper counts to ThreadHeapStatsCollector Bug: chromium:840789 Change-Id: I3dd9fda767c8591ad360fc96e05dda96f930672a Reviewed-on: https://chromium-review.googlesource.com/1092614 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565786} [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/bindings/core/v8/v8_gc_controller.cc [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/platform/bindings/wrapper_type_info.h [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/platform/heap/heap.cc [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/platform/heap/heap_page.cc [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/platform/heap/heap_stats_collector.cc [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/platform/heap/heap_stats_collector.h [modify] https://crrev.com/32c61869c629d800bd3e91fe9f7656aec93b425c/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98f3caf50aee5c269425e2ab529d1e2737f6ce5b commit 98f3caf50aee5c269425e2ab529d1e2737f6ce5b Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Jun 11 04:54:03 2018 [oilpan] Cleanup unused marking time Bug: chromium:840789 Change-Id: I303ab87bf929f0b9384b20333aea00abeef21fda Reviewed-on: https://chromium-review.googlesource.com/1094757 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565927} [modify] https://crrev.com/98f3caf50aee5c269425e2ab529d1e2737f6ce5b/third_party/blink/renderer/platform/heap/thread_state.cc [modify] https://crrev.com/98f3caf50aee5c269425e2ab529d1e2737f6ce5b/third_party/blink/renderer/platform/heap/thread_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aceb7d670d0cca38d219cadfc529390c755c299c commit aceb7d670d0cca38d219cadfc529390c755c299c Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Jun 11 11:40:36 2018 [oilpan] Fix for EsimateLiveSize Take current value for base size, similarly to what is used for PartitionAlloc. This makes sure that an esimate is computed at the time of calling the method. Bug: chromium:840789 Change-Id: Iab7e63f5395cbc74226cd786d420c6145fdb7dd9 Reviewed-on: https://chromium-review.googlesource.com/1094822 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565967} [modify] https://crrev.com/aceb7d670d0cca38d219cadfc529390c755c299c/third_party/blink/renderer/platform/heap/thread_state.cc [modify] https://crrev.com/aceb7d670d0cca38d219cadfc529390c755c299c/third_party/blink/renderer/platform/heap/thread_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2219598ce4dca095b4ef6659dfe823d76925541 commit e2219598ce4dca095b4ef6659dfe823d76925541 Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Jun 11 12:26:00 2018 [oilpan] Move CappedSizeInKB back to .cc file The method is now exclusively used from thread_state.cc and there are no more duplicates defined elsewhere which could break jumbo builds. Bug: chromium:840789 Change-Id: I09fa55c01f60eda79d2c08707d0520e8f3b1cfda Reviewed-on: https://chromium-review.googlesource.com/1095056 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#565973} [modify] https://crrev.com/e2219598ce4dca095b4ef6659dfe823d76925541/third_party/blink/renderer/platform/heap/heap.h [modify] https://crrev.com/e2219598ce4dca095b4ef6659dfe823d76925541/third_party/blink/renderer/platform/heap/thread_state.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee commit 74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Jun 14 04:22:43 2018 Revert "[oilpan] Fix for EsimateLiveSize" This reverts commit aceb7d670d0cca38d219cadfc529390c755c299c. Reason for revert: Even though the heuristic seems off we tuned parameters around it that will trigger GCs. Bug: 852413 Original change's description: > [oilpan] Fix for EsimateLiveSize > > Take current value for base size, similarly to what is used for > PartitionAlloc. This makes sure that an esimate is computed at the time > of calling the method. > > Bug: chromium:840789 > Change-Id: Iab7e63f5395cbc74226cd786d420c6145fdb7dd9 > Reviewed-on: https://chromium-review.googlesource.com/1094822 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565967} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:840789 Change-Id: I323527b2f6d4703773ca11f980a4233cb8554f7a Reviewed-on: https://chromium-review.googlesource.com/1100435 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567131} [modify] https://crrev.com/74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee/third_party/blink/renderer/platform/heap/thread_state.cc [modify] https://crrev.com/74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee/third_party/blink/renderer/platform/heap/thread_state.h
Comment 1 by bugdroid1@chromium.org
, May 8 2018