New issue
Advanced search Search tips

Issue 840785 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

[Missing Test]:Array#splice 40% slowdown

Project Member Reported by sindhu.chelamcherla@chromium.org, May 8 2018

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/v8/v8.git/+/e570e67383577c7f5ab6da7beb68631bab4ba75d

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=835558

Thank you.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f728d6984d74888495382f0594896e6510e49831

commit f728d6984d74888495382f0594896e6510e49831
Author: Camillo Bruni <cbruni@chromium.org>
Date: Tue May 29 15:06:48 2018

[js-perf-test] Consistently use createSuite in all benchmarks

Change-Id: I7bf0144bacd0572a42b98d0a0f19df3daf63128b
Bug: chromium:840785
Reviewed-on: https://chromium-review.googlesource.com/1051240
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53418}
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Array/from.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Array/join.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Array/of.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Array/run.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Array/to-string.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/ArraySort/run.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/ArraySort/sort-cmpfn-kindchange.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/ArraySort/sort-cmpfn.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/ArraySort/sort-presorted.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/ArraySort/sort.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Inspector/debugger.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Strings/run.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Strings/string-startsendswith-comp.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Strings/string-stringat-comp.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/Strings/string-substring.js
[modify] https://crrev.com/f728d6984d74888495382f0594896e6510e49831/test/js-perf-test/base.js

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d845d28ecff96b4bf0f1197357e8bc40ae214217

commit d845d28ecff96b4bf0f1197357e8bc40ae214217
Author: Camillo Bruni <cbruni@chromium.org>
Date: Mon Aug 13 10:14:38 2018

[js-perf-tests] Cleanup and more elements kind helpers

Bug: chromium:840785
Change-Id: I93f417084cc3ad3d1b906bdbef5dda14ead208c6
Reviewed-on: https://chromium-review.googlesource.com/1169044
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55082}
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/every.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/filter.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/find-index.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/find.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/for-each.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/map.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/reduce-right.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/reduce.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/run.js
[modify] https://crrev.com/d845d28ecff96b4bf0f1197357e8bc40ae214217/test/js-perf-test/Array/some.js

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1fc3dc2fcfe58decc07154760b1a51897521e22d

commit 1fc3dc2fcfe58decc07154760b1a51897521e22d
Author: Camillo Bruni <cbruni@chromium.org>
Date: Mon Aug 13 14:15:30 2018

[js-perf-test] Fixing JavaScript errors in Array/run.js

Bug: chromium:840785
Change-Id: I043df7aa5203dec27b84636c64286d68a56fba31
Reviewed-on: https://chromium-review.googlesource.com/1172428
Reviewed-by: Dan Elphick <delphick@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55088}
[modify] https://crrev.com/1fc3dc2fcfe58decc07154760b1a51897521e22d/test/js-perf-test/Array/run.js

Labels: -Pri-1 Pri-3

Sign in to add a comment