New issue
Advanced search Search tips

Issue 840782 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression

Blocked on:
issue 856640
issue 837210


Show other hotlists

Hotlists containing this issue:
Slim-Nav-Burndown


Sign in to add a comment

Page appears blank on reloading the offline webpage

Project Member Reported by rakurati@chromium.org, May 8 2018

Issue description

App Version: 67.0.3396.36 Beta
iOS Version: 10.3.3, 11.3
Device: iPhone and iPad

Steps to reproduce: 
1. Launch chrome and add a distilled webpage to read later
2. Enable #slim-navigation-manager from about://flags
3. Turn off the device wifi
4. Cold start chrome and open distilled webpage 
5. Once the webpage is loaded, tap on reload button

Observed result:
Page appears blank

Expected result: 
Offline version of the page should be displayed on reload

Revision Number for 67.0.3396.20(Bad Version) - 2414f891245c
Revision Number for 67.0.3396.19(Good Version) - f9749cbb3cc5

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested 
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA 
Bug reproducible on current stable build (App Version, iOS Version): No on M66 (Feature is available from M67)
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M67 Beta

Link to video:

Bad version:
https://drive.google.com/file/d/1u5ydsCUckMYMl9FND9G3cVO2xfJ-iJxa/view?usp=sharing

Good version:
https://drive.google.com/file/d/1KG3gX74TI6hHuMoJrKVSqdQnaTe-I_x5/view?usp=sharing
 
Cc: danyao@chromium.org
Components: UI>Browser>Navigation

Comment 2 by sczs@chromium.org, May 9 2018

Cc: -danyao@chromium.org
Labels: ReleaseBlock-Stable M-68
Owner: danyao@chromium.org
Status: Assigned (was: Untriaged)
danyao@ could you PTAL?

Comment 3 by danyao@chromium.org, May 15 2018

This is likely related to crbug/836767

Comment 4 by danyao@chromium.org, May 25 2018

Cc: eugene...@chromium.org olivierrobin@chromium.org
This is caused by OfflinePageNativeContent's |restoreOnlineURL| method trying to reload the online content by simply changing the URL of the NavigationItem. With WKBasedNavigationManager, this has no effect because reload is handled by WKWebView. Because the offline native content is backed by a placeholder URL, reload simply reloads the the placeholder URL in the web view.

The correct solution is to use a state machine similar to that used in reloading native error: https://docs.google.com/document/d/1gpmJnHnChm5xWeUhie8wW6Rq-0PHw0vU2myAJ0kIukA/edit#heading=h.wndz2y2yntcn
Cc: kariahda@chromium.org
Danyao - any update here?
Sorry no update here yet.
Labels: -M-68 M-69
Deferring this to M69 because we decided to not launch SlimNav in M68 per discussion with pinkerton@.
Blockedon: 856640
Labels: -Pri-2 Pri-1
Blockedon: 837210
Labels: -M-69 M-70
Labels: -ReleaseBlock-Stable -M-70

Comment 13 by danyao@chromium.org, Yesterday (43 hours ago)

Owner: ----

Sign in to add a comment