New issue
Advanced search Search tips

Issue 840776 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to blink::LayoutSVGResourceContainer from invalid vptr in blink::SVGResources::RemoveClientFromCacheAffectingObjectBounds

Project Member Reported by ClusterFuzz, May 8 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6319469581041664

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x1347bbc1c2e8
Crash State:
  Bad-cast to blink::LayoutSVGResourceContainer from invalid vptr
  blink::SVGResources::RemoveClientFromCacheAffectingObjectBounds
  blink::RemoveFromCacheAndInvalidateDependencies
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=556742:556743

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6319469581041664

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 8 2018

Components: Blink>SVG
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 8 2018

Labels: Test-Predator-Auto-Owner
Owner: f...@opera.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/3431b89c8be2d7b1a60f5eb135b1d27ce432ce9b ([CI] Convert SVG resources to use SVGResource).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, May 8 2018

Labels: M-68
Project Member

Comment 4 by sheriffbot@chromium.org, May 8 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, May 8 2018

Labels: Pri-1
fs@, note that if the fix is difficult you could revert the change then fix this issue and reland.

Comment 7 by f...@opera.com, May 8 2018

I figured I'd let the fuzzers have at it for a while to flush out the worst things.
Project Member

Comment 8 by ClusterFuzz, May 10 2018

ClusterFuzz has detected this issue as fixed in range 557119:557122.

Detailed report: https://clusterfuzz.com/testcase?key=6319469581041664

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x1347bbc1c2e8
Crash State:
  Bad-cast to blink::LayoutSVGResourceContainer from invalid vptr
  blink::SVGResources::RemoveClientFromCacheAffectingObjectBounds
  blink::RemoveFromCacheAndInvalidateDependencies
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=556742:556743
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=557119:557122

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6319469581041664

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, May 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6319469581041664 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, May 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 16

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment