New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840751 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Test]: When VP9 videos are played using MSE - colors are slightly faded

Project Member Reported by susan.boorgula@chromium.org, May 8 2018

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/f8b28baae80f3c8ce1f52d38a845152a52070c88

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=827893

Thank you.
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d75f0ee67ef8a485c7436baeae5b359fcb047dd

commit 3d75f0ee67ef8a485c7436baeae5b359fcb047dd
Author: Fredrik Hubinette <hubbe@google.com>
Date: Mon May 21 22:00:46 2018

Add test for unspecified range in webm parser

Bug:  840751 
Change-Id: Iedd393cfc3b11d11dbc60b87c9f3a747a7463116
Reviewed-on: https://chromium-review.googlesource.com/1065131
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560369}
[modify] https://crrev.com/3d75f0ee67ef8a485c7436baeae5b359fcb047dd/media/formats/webm/webm_stream_parser_unittest.cc
[add] https://crrev.com/3d75f0ee67ef8a485c7436baeae5b359fcb047dd/media/test/data/colour_unspecified_range.webm

Comment 2 by hubbe@chromium.org, May 21 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59f7acb1efac8361935fcb4262f5af3771fa2e6

commit d59f7acb1efac8361935fcb4262f5af3771fa2e6
Author: Matt Wolenetz <wolenetz@chromium.org>
Date: Tue May 22 17:50:34 2018

MSE: Use a MATCHER instead of duplicated string in WebMStreamParserTests

Following comments on review
https://chromium-review.googlesource.com/c/chromium/src/+/1065131 this CL
refactors a set of duplicated expectations to instead use a common, new,
MATCHER.

BUG= 840751 

Change-Id: Ie2f0e9080478fab37d2c632f9c5d26244dbabd29
Reviewed-on: https://chromium-review.googlesource.com/1067739
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560693}
[modify] https://crrev.com/d59f7acb1efac8361935fcb4262f5af3771fa2e6/media/base/test_helpers.h
[modify] https://crrev.com/d59f7acb1efac8361935fcb4262f5af3771fa2e6/media/formats/webm/webm_stream_parser_unittest.cc

Sign in to add a comment