New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840731 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility

Blocking:
issue 856195



Sign in to add a comment

Regression: Accessibility settings overlay is getting chopped when clicking on space bar of On screen keyboard

Project Member Reported by kebalaji@chromium.org, May 8 2018

Issue description

Chrome Version: 68.0.3423.0/10657.0.0 dev channel Celes,Kip,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE screen, enable On-screen keyboard
(2)Now tab and keep focus on Chromevox ( Refer video)
(3)Click on the space bar of On screen keyboard and observe

Actual: The Accessibility settings overlay is seen chopped 
Expected: No such issue should be seen

This is a Regression issue as same is working fine in 67.0.3396.26/10575.22.0 dev


 
ActualChoppedOverlay.mp4
5.6 MB View Download
ExpectedChoppedOverlay.mp4
5.7 MB View Download
Owner: iloahz@chromium.org
@iloahz: Please confirm the issue 
Status: Assigned (was: Untriaged)
Any update on this?

It is marked as a R68 stable blocker and we are nearing stable in the next couple weeks.
Sorry for missing this, the whole team is occupied by the NewUI.

I'll investigate this ASAP.
Owner: shend@chromium.org
Hi shend@,

This doesn't look like an issue on extension side, can you help take a look at this?
Cc: iloahz@chromium.org
My current suspicion:

1. When ChromeVox turns on, the IME extension refreshes itself (by dispatching EventType.REFRESH).
2. In 68, we changed the keyboard window background from grey to transparent (for fullscreen handwriting). So refreshing the extension reveals the "chopped" overlay.

I can't think of a good fix ATM, so I think it's best if we make the keyboard window transparent only for fullscreen handwriting or the New UI.

iloahz@, do we still refresh the keyboard for the new UI? If so, we need a real fix for this bug. Would it be possible to refresh the IME while still maintaining a grey background?
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe9d17a5c810a1955c00d0546f6c82537c63aa4

commit fbe9d17a5c810a1955c00d0546f6c82537c63aa4
Author: Darren Shen <shend@chromium.org>
Date: Wed Jul 18 07:23:10 2018

[VK] Do not make keyboard window background transparent for old UI.

In [1] and [2], we changed the keyboard background to be transparent.
However, when the IME extension refreshes itself (e.g. due to ChromeVox
activation), the keyboard becomes see through, which is bad (see bug).

We basically put the changes to window background in [1] and [2] behind
two flags (enable-fullscreen-handwriting-virtual-keyboard and
enable-virtual-keyboard-md-ui), both of which are currently disabled
by default.

This should fix the attached bug. We will come up with permanent
solution when we need to launch fullscreen handwriting or the new UI.

This needs to be merged in M68.

[1] https://crrev.com/7c1b43d13f6c914c496dae48b1c392ee6e045794
[2] https://crrev.com/2d463f5527d6d5b4b82fbb563798462793c3b6f2

Bug:  840731 
Change-Id: I937b492986291e9aebfc15fab03f6123aba04dec
Reviewed-on: https://chromium-review.googlesource.com/1141546
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575966}
[modify] https://crrev.com/fbe9d17a5c810a1955c00d0546f6c82537c63aa4/chrome/browser/ui/ash/chrome_keyboard_ui.cc

Labels: Merge-Request-68
Requesting merge to M68 for c#7. Thanks!
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 18

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 856195
Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 20

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42d5b0006a7e65fe8065391b5f211d68fed7b61

commit f42d5b0006a7e65fe8065391b5f211d68fed7b61
Author: Darren Shen <shend@chromium.org>
Date: Fri Jul 20 00:02:41 2018

[Merge M68] Do not make keyboard window background transparent.

Cherry picked from fbe9d17a5c810a1955c00d0546f6c82537c63aa4
Main difference is that the enable-virtual-keyboard-md-ui flag did not
exist in M68, so we only make window transparent for fullscreen
handwriting.

TBR=yhanada@chromium.org

-----------------------------------------------------------------------

In [1] and [2], we changed the keyboard background to be transparent.
However, when the IME extension refreshes itself (e.g. due to ChromeVox
activation), the keyboard becomes see through, which is bad (see bug).

We basically put the changes to window background in [1] and [2] behind
two flags (enable-fullscreen-handwriting-virtual-keyboard and
enable-virtual-keyboard-md-ui), both of which are currently disabled
by default.

This should fix the attached bug. We will come up with permanent
solution when we need to launch fullscreen handwriting or the new UI.

This needs to be merged in M68.

[1] https://crrev.com/7c1b43d13f6c914c496dae48b1c392ee6e045794
[2] https://crrev.com/2d463f5527d6d5b4b82fbb563798462793c3b6f2

(cherry picked from commit fbe9d17a5c810a1955c00d0546f6c82537c63aa4)

Bug:  840731 
Change-Id: I937b492986291e9aebfc15fab03f6123aba04dec
Reviewed-on: https://chromium-review.googlesource.com/1141546
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#575966}
Reviewed-on: https://chromium-review.googlesource.com/1143668
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#720}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/f42d5b0006a7e65fe8065391b5f211d68fed7b61/chrome/browser/ui/ash/chrome_keyboard_ui.cc

Status: Fixed (was: Assigned)
Should be fixed in M68, but we need to ensure that this doesn't happen in the new UI either.

Sign in to add a comment