New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840725 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 840638
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

"org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting__CustomTabActivity" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 8 2018

Issue description

"org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting__CustomTabActivity" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyfgsSBUZsYWtlInNvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIudnJfc2hlbGwuV2ViVnJUcmFuc2l0aW9uVGVzdCN0ZXN0V2luZG93UmFmU3RvcHNGaXJpbmdXaGlsZVByZXNlbnRpbmdfX0N1c3RvbVRhYkFjdGl2aXR5DA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: bsheedy@chromium.org
Components: UI>Browser>VR
Labels: -Pri-1 -Sheriff-Chromium OS-Android Pri-2
Status: (was: Untriaged)
Disabling the test and removing from sheriff queue.

mthiesse@: Assigning to you since you are listed OWNER. If you are not the right owner for this, please help with triage.

Owner: mthiesse@chromium.org
Status: Assigned
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f41d1dafcaadacf666b20b0d0aa32228295a9e0

commit 1f41d1dafcaadacf666b20b0d0aa32228295a9e0
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue May 08 11:57:59 2018

Disable flaky WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting on Android

TBR=bsheedy@chromium.org

Bug:  840725 
Change-Id: Id47604a849bcfcbb51e33ddf94ffa7a539ecb1df
Reviewed-on: https://chromium-review.googlesource.com/1049668
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556762}
[modify] https://crrev.com/1f41d1dafcaadacf666b20b0d0aa32228295a9e0/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java

Cc: bshe@chromium.org
 Issue 840925  has been merged into this issue.
Mergedinto: 840638
Status: Duplicate (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da8edb2734260899f9cb45e22a3899861a8dc4a3

commit da8edb2734260899f9cb45e22a3899861a8dc4a3
Author: Eric Karl <ericrk@chromium.org>
Date: Thu May 10 20:42:56 2018

Revert "Disable flaky WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting on Android"

This reverts commit 1f41d1dafcaadacf666b20b0d0aa32228295a9e0.

Reason for revert: These flakes are addressed with  https://chromium.googlesource.com/chromium/src.git/+/044cca4ad8bc7a80c6edbd4e8dd4d078fd5f7659

Original change's description:
> Disable flaky WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting on Android
> 
> TBR=bsheedy@chromium.org
> 
> Bug:  840725 
> Change-Id: Id47604a849bcfcbb51e33ddf94ffa7a539ecb1df
> Reviewed-on: https://chromium-review.googlesource.com/1049668
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556762}

TBR=guidou@chromium.org,bsheedy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  840725 
Change-Id: Ie558ae22bc52438a919ccf0a49d15bea6d2ab424
Reviewed-on: https://chromium-review.googlesource.com/1054350
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557661}
[modify] https://crrev.com/da8edb2734260899f9cb45e22a3899861a8dc4a3/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java

Sign in to add a comment