New issue
Advanced search Search tips

Issue 840724 link

Starred by 1 user
Status: Unconfirmed
Owner: ----
Cc:
vapier@chromium.org
jwer...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

git-clang-format: git diff invocation should use --no-ext-diff

Project Member Reported by vapier@chromium.org, May 8 2018 
use of diff.external in ~/.gitconfig can mess up clang-format.  it should make sure to invoke `git diff` with `--no-ext-diff`.

not sure where the code is that actually invokes this, so over to c-i-t to triage

Comment 1 by jwer...@chromium.org, Aug 20

Summary: git-clang-format: git diff invocation should use --no-ext-diff (was: clang-format: git diff invocation should use --no-ext-diff)
*ping*

Can we get any movement on this? Does anyone even subscribe to this component?

This doesn't just mess up output, it outright makes git-clang-format fail and forces you to skip presubmits if you want to upload anything. If we want to have effective presubmit checks that people actually run, and we want to use git-clang-format in them, then this is not a tenable situation. diff.external is not a rare fringe case for git users, it is very commonly used.
►

Sign in to add a comment